Add ArcticPCB pre-Alpha support #8479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Mar 21, 2020
fauxpark
approved these changes
Mar 21, 2020
noroadsleft
requested changes
Mar 24, 2020
Use the LAYOUT_60_tsangan_hhkb Community Layout Co-Authored-By: James Young <[email protected]>
|
Thank you for your contribution! |
zvecr
reviewed
May 13, 2020
| #include QMK_KEYBOARD_H | ||
|
|
||
| const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | ||
| [0] = LAYOUT_60_tsangan_hhkb( |
There was a problem hiding this comment.
Given default also uses LAYOUT_60_tsangan_hhkb, i'm not sure how much value this keymap adds.
There was a problem hiding this comment.
Aside from this, it LGTM.
I would prefer an answer here before it gets merged.
There was a problem hiding this comment.
Keymap removed in 75a666c
Erovia
requested changes
Jun 22, 2020
tzarc
requested changes
Jul 25, 2020
noroadsleft
requested changes
Aug 4, 2020
Co-authored-by: James Young <[email protected]>
|
Thanks! |
nicocesar
pushed a commit
to nicocesar/qmk_firmware
that referenced
this pull request
Aug 12, 2020
* Add initial ArcticPCB support * Added README * Solve info.json comma issue * Apply suggestions from noroadsleft code review Use the LAYOUT_60_tsangan_hhkb Community Layout * Apply suggestions from tzarc * Add license header to arctic.c, arctic.h and config.h * Remove redundant tsangan keymap * Remove tsangan compilation suggestion from readme
fcoury
pushed a commit
to fcoury/qmk_firmware_archive
that referenced
this pull request
Sep 20, 2020
* Add initial ArcticPCB support * Added README * Solve info.json comma issue * Apply suggestions from noroadsleft code review Use the LAYOUT_60_tsangan_hhkb Community Layout * Apply suggestions from tzarc * Add license header to arctic.c, arctic.h and config.h * Remove redundant tsangan keymap * Remove tsangan compilation suggestion from readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the pre-revision Alpha version of the ArcticPCB. A revised Alpha version is underway, which firmware will be added later.
Two layouts are offered, one "default" and a "tsangan" one.
Types of Changes
Checklist