Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chidori OLED-enabled sample keymap #8446

Merged
merged 9 commits into from
May 9, 2020
Merged

Add Chidori OLED-enabled sample keymap #8446

merged 9 commits into from
May 9, 2020

Conversation

1m38
Copy link
Contributor

@1m38 1m38 commented Mar 16, 2020 •
edited
Loading

Description

Adding a keymap chidori:oled_sample, an OLED enabled sample keymap based on chidori:default.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested a review from a team March 17, 2020 23:05
drashna
drashna requested changes Mar 18, 2020
View reviewed changes
keyboards/chidori/keymaps/oled_sample/keymap.c Outdated Show resolved Hide resolved
keyboards/chidori/keymaps/oled_sample/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team March 23, 2020 00:52
@zvecr zvecr requested review from drashna and fauxpark March 26, 2020 02:27
@drashna drashna requested a review from a team May 9, 2020 06:41
@noroadsleft noroadsleft merged commit e2fa05c into qmk:master May 9, 2020
@noroadsleft
Copy link
Member

Thanks!

bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@1m38 @lorenzoernesto
[Keymap] Add Chidori OLED-enabled sample keymap (qmk#8446)
8958a83 
* create chidori/oled_sample keymap

* Implement OLED enabled keymap

* Update readme.md

* Update keyboards/chidori/keymaps/oled_sample/keymap.c

* Update keyboards/chidori/keymaps/oled_sample/keymap.c

* delete chidori:oled_sample/config.h

* use oled_write_ln_P to print layer state

* delete unnecessary include

* merge nested switches in oled_write_layer_state()
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@1m38 @sowbug
[Keymap] Add Chidori OLED-enabled sample keymap (qmk#8446)
7e2e8f9 
* create chidori/oled_sample keymap

* Implement OLED enabled keymap

* Update readme.md

* Update keyboards/chidori/keymaps/oled_sample/keymap.c

* Update keyboards/chidori/keymaps/oled_sample/keymap.c

* delete chidori:oled_sample/config.h

* use oled_write_ln_P to print layer state

* delete unnecessary include

* merge nested switches in oled_write_layer_state()
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@1m38 @turky
[Keymap] Add Chidori OLED-enabled sample keymap (qmk#8446)
433ad48 
* create chidori/oled_sample keymap

* Implement OLED enabled keymap

* Update readme.md

* Update keyboards/chidori/keymaps/oled_sample/keymap.c

* Update keyboards/chidori/keymaps/oled_sample/keymap.c

* delete chidori:oled_sample/config.h

* use oled_write_ln_P to print layer state

* delete unnecessary include

* merge nested switches in oled_write_layer_state()
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@1m38 @jakobaa
[Keymap] Add Chidori OLED-enabled sample keymap (qmk#8446)
3df1821 
* create chidori/oled_sample keymap

* Implement OLED enabled keymap

* Update readme.md

* Update keyboards/chidori/keymaps/oled_sample/keymap.c

* Update keyboards/chidori/keymaps/oled_sample/keymap.c

* delete chidori:oled_sample/config.h

* use oled_write_ln_P to print layer state

* delete unnecessary include

* merge nested switches in oled_write_layer_state()
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@1m38 @sjmacneil
[Keymap] Add Chidori OLED-enabled sample keymap (qmk#8446)
04ae937 
* create chidori/oled_sample keymap

* Implement OLED enabled keymap

* Update readme.md

* Update keyboards/chidori/keymaps/oled_sample/keymap.c

* Update keyboards/chidori/keymaps/oled_sample/keymap.c

* delete chidori:oled_sample/config.h

* use oled_write_ln_P to print layer state

* delete unnecessary include

* merge nested switches in oled_write_layer_state()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1m38 @noroadsleft @drashna @fauxpark