-
-
Notifications
You must be signed in to change notification settings - Fork 39.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new keymap with split shift and split backspace for bananasplit PCB #8395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noroadsleft
requested changes
Mar 12, 2020
keyboards/thevankeyboards/bananasplit/keymaps/cijanzen/config.h
Outdated
Show resolved
Hide resolved
christopherjanzen
requested review from
noroadsleft
and removed request for
a team
March 12, 2020 12:39
noroadsleft
approved these changes
Mar 12, 2020
fauxpark
reviewed
Mar 12, 2020
keyboards/thevankeyboards/bananasplit/keymaps/cijanzen/keymap.c
Outdated
Show resolved
Hide resolved
Co-Authored-By: Ryan <[email protected]>
fauxpark
approved these changes
Mar 12, 2020
Thanks! |
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Mar 14, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (27 commits) Add Portuguese keymap and sendstring lookup tables (qmk#8390) Update link for Learn Plover google site (qmk#8410) [Keymap] ninjonas keymap updates (qmk#8373) Fix bootloader for Maypad (qmk#8411) Add decorators for determining keyboard and keymap based on current directory (qmk#8191) format code according to conventions [skip ci] Fix pressing two keys with the same keycode but different modifiers (qmk#2710) format code according to conventions [skip ci] Decouple mouse cursor and mouse wheel in accelerated mode (qmk#6685) [Keyboard] Add Wallaby (qmk#8398) [Keyboard] Abacus Keyboard ReMerge (qmk#8308) Restore getting_started_github.md doc Update Swedish keymap and add sendstring LUT (qmk#8365) Update Spanish keymap and sendstring LUT (qmk#8364) use qmk.path.normpath to locate the output file. [Keyboard] Candybar update (qmk#8335) Add new keymap with split shift and split backspace for bananas… (qmk#8395) Enable custom backlight driver for kmac (qmk#8397) Force "blank" issue template to end of list (qmk#8387) Fix darkmode (qmk#8393) ...
c0psrul3
pushed a commit
to c0psrul3/qmk_firmware
that referenced
this pull request
Mar 23, 2020
…#8395) * Add new keymap with split right shift and split backspace for bananasplit PCB * Remove unecessary config.h * Remove unecessary line breaks Co-Authored-By: Ryan <[email protected]> Co-authored-by: Christopher Janzen <[email protected]> Co-authored-by: Ryan <[email protected]>
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
Apr 2, 2020
…#8395) * Add new keymap with split right shift and split backspace for bananasplit PCB * Remove unecessary config.h * Remove unecessary line breaks Co-Authored-By: Ryan <[email protected]> Co-authored-by: Christopher Janzen <[email protected]> Co-authored-by: Ryan <[email protected]>
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Apr 10, 2020
…#8395) * Add new keymap with split right shift and split backspace for bananasplit PCB * Remove unecessary config.h * Remove unecessary line breaks Co-Authored-By: Ryan <[email protected]> Co-authored-by: Christopher Janzen <[email protected]> Co-authored-by: Ryan <[email protected]>
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
…#8395) * Add new keymap with split right shift and split backspace for bananasplit PCB * Remove unecessary config.h * Remove unecessary line breaks Co-Authored-By: Ryan <[email protected]> Co-authored-by: Christopher Janzen <[email protected]> Co-authored-by: Ryan <[email protected]>
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
…#8395) * Add new keymap with split right shift and split backspace for bananasplit PCB * Remove unecessary config.h * Remove unecessary line breaks Co-Authored-By: Ryan <[email protected]> Co-authored-by: Christopher Janzen <[email protected]> Co-authored-by: Ryan <[email protected]>
jakeisnt
pushed a commit
to jakeisnt/qmk_firmware
that referenced
this pull request
Aug 20, 2020
…#8395) * Add new keymap with split right shift and split backspace for bananasplit PCB * Remove unecessary config.h * Remove unecessary line breaks Co-Authored-By: Ryan <[email protected]> Co-authored-by: Christopher Janzen <[email protected]> Co-authored-by: Ryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides an HHKB-like layout for the Bananasplit PCB
Types of Changes
Issues Fixed or Closed by This PR
Checklist