Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bootloader definition for namecard2x4 keyboard #8301

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

shelaf
Copy link
Contributor

@shelaf shelaf commented Mar 3, 2020

BOOTLOADER needs to be defined as caterina because namecard2x4 keyboard uses avrdude for flasher.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

tag: @takashiski

BOOTLOADER needs to be defined as caterina because namecard2x4 uses avrdude for flasher.
@fauxpark fauxpark requested a review from a team March 3, 2020 14:56
@zvecr zvecr merged commit acaecb4 into qmk:master Mar 3, 2020
@zvecr
Copy link
Member

zvecr commented Mar 3, 2020

Thanks!

@shelaf shelaf deleted the fix/naemcard2x4 branch March 3, 2020 16:17
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Mar 5, 2020
BOOTLOADER needs to be defined as caterina because namecard2x4 uses avrdude for flasher.
nesth pushed a commit to nesth/qmk_firmware that referenced this pull request Mar 5, 2020
* upstream/master: (37 commits)
  Add RGB lighting through one of the free pins (qmk#8294)
  [Keymap] Adding the 4sStylZ xd75 (qmk#8285)
  YD60MQ refactor and Configurator layout support (qmk#8313)
  [Keyboard] Forget to ifdef Super16 led config (qmk#8314)
  [Keyboard] Switch to RGB Matrix for Super16 (qmk#8305)
  [Keymap] Keymap Update (qmk#8309)
  New Keyboard: SiddersKB Majbritt (Pronounced My Brit) (qmk#8260)
  [Keyboard] VIA Support: Tada68 (qmk#8289)
  [Keyboard] LFK78 refactor (qmk#7835)
  [Keymap] new userspace for ibnuda (qmk#8221)
  [Keymap] Add crd's equinox keymap (qmk#8251)
  [Keymap] Feature/alfrdmalr/keymap update (qmk#8174)
  Fix bootloader definition for namecard2x4 (qmk#8301)
  Update Hungarian keymap and add sendstring LUT (qmk#8220)
  Remove "ugly hack in usb_main.c" comments (qmk#8296)
  Update encoder functions for Iris VIA keymap (qmk#8295)
  Reduce PROGMEM usage for sendstring LUT (qmk#8109)
  [Docs] Update ISP Flashing guide (qmk#8149)
  Rewrite the Bathroom Epiphanies Frosty Flake matrix and LED handling (qmk#8243)
  Add onekey keymap for testing reset to bootloader. (qmk#8288)
  ...
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
BOOTLOADER needs to be defined as caterina because namecard2x4 uses avrdude for flasher.
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request Apr 2, 2020
BOOTLOADER needs to be defined as caterina because namecard2x4 uses avrdude for flasher.
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
BOOTLOADER needs to be defined as caterina because namecard2x4 uses avrdude for flasher.
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
BOOTLOADER needs to be defined as caterina because namecard2x4 uses avrdude for flasher.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants