Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New keymap layout for dztech/dz65rgb/keymaps #8199

Merged
merged 9 commits into from
May 7, 2020
Merged

New keymap layout for dztech/dz65rgb/keymaps #8199

merged 9 commits into from
May 7, 2020

Conversation

drootz
Copy link
Contributor

@drootz drootz commented Feb 18, 2020 •
edited
Loading

Description

New keymap layout for dztech/dz65rgb/keymaps

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drootz
New keymap layout for dztech/dz65rgb/keymaps
bba7c70
@drootz
New keymap layout for dztech/dz65rgb/keymaps
84bc61b 
- Conding conventions fixes
@drootz
Merge branch 'master' into dz65_drootz
16e00da 
* master:
  Made windows driver installation accept y as All to allow CI (qmk#8189)
drootz added a commit to drootz/qmk_firmware that referenced this pull request Feb 18, 2020
@drootz
Temporary Branch of PR qmk#8199. Will be deleted once merged in main …
2042ed9 
…QMK repo.
@noroadsleft noroadsleft requested a review from a team February 19, 2020 02:18
@drashna drashna requested a review from a team February 21, 2020 02:09
@drootz
Fixed data types and function names - Simplified accent macros by rem…
971fb94 
…oving repetition - Added selection wrap macros - readme.md doc updated with changes
@drootz
PR qmk#8199 second feedback commit - Clarified function names, variab…
22402dc 
…les names and comments
drootz added a commit to drootz/qmk_firmware that referenced this pull request Feb 21, 2020
@drootz
Merge branch 'dz65_drootz_dev' into dz65_drootz_tmppr
92b091a 
* dz65_drootz_dev:
  PR qmk#8199 second feedback commit - Clarified function names, variables names and comments
  Fixed data types and function names - Simplified accent macros by removing repetition - Added selection wrap macros - readme.md doc updated with changes
  PR qmk#8199 Feedback Commit qmk#1
  Fix typo in Leader Key table
@stale
Copy link

stale bot commented Apr 15, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Apr 28, 2020
@drashna drashna requested a review from a team April 28, 2020 07:09
@noroadsleft noroadsleft merged commit 923bad4 into qmk:master May 7, 2020
@noroadsleft
Copy link
Member

Thanks!

brandonschlack pushed a commit to brandonschlack/qmk_firmware that referenced this pull request May 7, 2020
@drootz @brandonschlack
[Keymap] New keymap layout for dztech/dz65rgb/keymaps (qmk#8199)
c8e0732 
* New keymap layout for dztech/dz65rgb/keymaps

* New keymap layout for dztech/dz65rgb/keymaps
- Conding conventions fixes

* Fix typo in Leader Key table

* PR qmk#8199 Feedback Commit qmk#1

* Fixed data types and function names - Simplified accent macros by removing repetition - Added selection wrap macros - readme.md doc updated with changes

* PR qmk#8199 second feedback commit - Clarified function names, variables names and comments

* Fix: accent output fix _grave  <==> _circumflex

* dry fixes on led set_color with hsv and led blinking code blocks
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@drootz @lorenzoernesto
[Keymap] New keymap layout for dztech/dz65rgb/keymaps (qmk#8199)
49d0093 
* New keymap layout for dztech/dz65rgb/keymaps

* New keymap layout for dztech/dz65rgb/keymaps
- Conding conventions fixes

* Fix typo in Leader Key table

* PR qmk#8199 Feedback Commit qmk#1

* Fixed data types and function names - Simplified accent macros by removing repetition - Added selection wrap macros - readme.md doc updated with changes

* PR qmk#8199 second feedback commit - Clarified function names, variables names and comments

* Fix: accent output fix _grave  <==> _circumflex

* dry fixes on led set_color with hsv and led blinking code blocks
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@drootz @sowbug
[Keymap] New keymap layout for dztech/dz65rgb/keymaps (qmk#8199)
aefca2c 
* New keymap layout for dztech/dz65rgb/keymaps

* New keymap layout for dztech/dz65rgb/keymaps
- Conding conventions fixes

* Fix typo in Leader Key table

* PR qmk#8199 Feedback Commit qmk#1

* Fixed data types and function names - Simplified accent macros by removing repetition - Added selection wrap macros - readme.md doc updated with changes

* PR qmk#8199 second feedback commit - Clarified function names, variables names and comments

* Fix: accent output fix _grave  <==> _circumflex

* dry fixes on led set_color with hsv and led blinking code blocks
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@drootz @turky
[Keymap] New keymap layout for dztech/dz65rgb/keymaps (qmk#8199)
3f650ec 
* New keymap layout for dztech/dz65rgb/keymaps

* New keymap layout for dztech/dz65rgb/keymaps
- Conding conventions fixes

* Fix typo in Leader Key table

* PR qmk#8199 Feedback Commit qmk#1

* Fixed data types and function names - Simplified accent macros by removing repetition - Added selection wrap macros - readme.md doc updated with changes

* PR qmk#8199 second feedback commit - Clarified function names, variables names and comments

* Fix: accent output fix _grave  <==> _circumflex

* dry fixes on led set_color with hsv and led blinking code blocks
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@drootz @jakobaa
[Keymap] New keymap layout for dztech/dz65rgb/keymaps (qmk#8199)
7f5ba23 
* New keymap layout for dztech/dz65rgb/keymaps

* New keymap layout for dztech/dz65rgb/keymaps
- Conding conventions fixes

* Fix typo in Leader Key table

* PR qmk#8199 Feedback Commit qmk#1

* Fixed data types and function names - Simplified accent macros by removing repetition - Added selection wrap macros - readme.md doc updated with changes

* PR qmk#8199 second feedback commit - Clarified function names, variables names and comments

* Fix: accent output fix _grave  <==> _circumflex

* dry fixes on led set_color with hsv and led blinking code blocks
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@drootz @sjmacneil
[Keymap] New keymap layout for dztech/dz65rgb/keymaps (qmk#8199)
5fe9ebc 
* New keymap layout for dztech/dz65rgb/keymaps

* New keymap layout for dztech/dz65rgb/keymaps
- Conding conventions fixes

* Fix typo in Leader Key table

* PR qmk#8199 Feedback Commit qmk#1

* Fixed data types and function names - Simplified accent macros by removing repetition - Added selection wrap macros - readme.md doc updated with changes

* PR qmk#8199 second feedback commit - Clarified function names, variables names and comments

* Fix: accent output fix _grave  <==> _circumflex

* dry fixes on led set_color with hsv and led blinking code blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drootz @noroadsleft @drashna