add lily58 yshrsmz keymap #8095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshrsmz
force-pushed
the
lily58-yshrsmz
branch
from
ad18c21 to
dacb9f4
Compare
drashna
approved these changes
Feb 5, 2020
fauxpark
requested changes
Feb 5, 2020
|
I've addressed all the requested changes. |
fauxpark
requested changes
Feb 6, 2020
|
Still just the rules.mk suggestion but otherwise looks good. |
|
Ah backslashes. sorry |
|
Yes, but the rest can go, since they are the same as in the keyboard-level rules.mk. |
|
updated the rules.mk to insert one item at a time. |
fauxpark
requested changes
Feb 7, 2020
fauxpark
approved these changes
Feb 7, 2020
|
Thanks! |
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Feb 8, 2020
* 'master' of https://github.com/qmk/qmk_firmware: (24 commits) CI: Add workflow for CLI testing (qmk#7357) Add Prime_L V2 and Prime_EXL Plus (qmk#8111) [Keyboard] adding keyboard: neuron (qmk#7980) [Keyboard] adding keyboard: pain27 (qmk#7977) [Keyboard] adding keyboard: sl40 (qmk#7978) [Keyboard] adding keyboard: houndstooth (qmk#7981) [Keyboard] adding keyboard: kodachi50 (qmk#7976) [Keyboard] adding keyboard: gothic70 (qmk#7982) [Keyboard] adding keyboard: gothic50 (qmk#7983) [Keyboard] YMDK NP21: matrix and keymap refactor (qmk#8112) [Keymap] Added keymap for keebio/nyquist (qmk#8108) [Keyboard] Port SPLIT_USB_DETECT to lily58 (qmk#8107) [Keymap] Phoebe/Maxr1998 keymap: enable space cadet with curly braces (qmk#8096) [Keymap] add lily58 yshrsmz keymap (qmk#8095) [Keyboard] Remove i2c write command when reading columns on Ergodox EZ (qmk#8092) [Keyboard] Misc tidyups for Chidori (qmk#8091) [Keymap] Add users/alfrdmalr and switch to layouts (qmk#8030) XD84: Configurator bugfix for ISO layout (qmk#8117) ZJ68: complete Configurator layout support (qmk#8116) Add QMK Compile Context Sensitivity (qmk#6884) ...
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
* add lily58 yshrsmz keymap * apply requested changes * remove more backslashes * remove more backslashes * update rules.mk
c0psrul3
pushed a commit
to c0psrul3/qmk_firmware
that referenced
this pull request
Mar 23, 2020
* add lily58 yshrsmz keymap * apply requested changes * remove more backslashes * remove more backslashes * update rules.mk
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
* add lily58 yshrsmz keymap * apply requested changes * remove more backslashes * remove more backslashes * update rules.mk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add lily58 yshrsmz keymap
Types of Changes
Issues Fixed or Closed by This PR
Checklist