Fix AVR boards which were overriding backlight without setting… #8044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
force-pushed
the
feature/avr_backlight_driver
branch
from
819168f to
28e2303
Compare
fauxpark
requested changes
Jan 30, 2020
keyboards/amj96/rules.mk
Outdated
| NKRO_ENABLE ?= yes # USB Nkey Rollover | ||
| BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality on B7 by default | ||
| NKRO_ENABLE = yes # USB Nkey Rollover | ||
| BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality on B7 by default |
There was a problem hiding this comment.
Suggested change
| BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality on B7 by default | |
| BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality |
This PCB seems to support backlight, no idea what the pin is though. I assume that's why you disabled it here.
There was a problem hiding this comment.
Yeah, the code wasnt functional as there was no BACKLIGHT_PIN defined. Currently it would have just had an empty backlight_set function. Given I dont have the board, I figured it best to disable.
fauxpark
requested changes
Jan 30, 2020
Co-Authored-By: fauxpark <[email protected]>
Co-Authored-By: fauxpark <[email protected]>
zvecr
force-pushed
the
feature/avr_backlight_driver
branch
from
7b13f60 to
9d0b4f3
Compare
fauxpark
approved these changes
Jan 30, 2020
fauxpark
changed the title
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
…8044) * Add backlight custom driver to all boards not declaring it but overriding backlight * Apply suggestions from code review Co-Authored-By: fauxpark <[email protected]> * Apply suggestions from code review Co-Authored-By: fauxpark <[email protected]> * Remove old tmk references from show_options.mk Co-authored-by: fauxpark <[email protected]>
13 tasks
c0psrul3
pushed a commit
to c0psrul3/qmk_firmware
that referenced
this pull request
Mar 23, 2020
…8044) * Add backlight custom driver to all boards not declaring it but overriding backlight * Apply suggestions from code review Co-Authored-By: fauxpark <[email protected]> * Apply suggestions from code review Co-Authored-By: fauxpark <[email protected]> * Remove old tmk references from show_options.mk Co-authored-by: fauxpark <[email protected]>
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
…8044) * Add backlight custom driver to all boards not declaring it but overriding backlight * Apply suggestions from code review Co-Authored-By: fauxpark <[email protected]> * Apply suggestions from code review Co-Authored-By: fauxpark <[email protected]> * Remove old tmk references from show_options.mk Co-authored-by: fauxpark <[email protected]>
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
…8044) * Add backlight custom driver to all boards not declaring it but overriding backlight * Apply suggestions from code review Co-Authored-By: fauxpark <[email protected]> * Apply suggestions from code review Co-Authored-By: fauxpark <[email protected]> * Remove old tmk references from show_options.mk Co-authored-by: fauxpark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another round of #7970, but this time for AVR.
Hangover from old AVR implementation within quantum.c, where you could use custom stuff without actually defining you were doing so. The reason you currently get away with it is the #ifdef BACKLIGHT_PIN wrapping quantum/backlight/backlight_avr.c
Types of Changes
Checklist