Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remnants of custom matrix from Skog rules.mk #7764

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Remove remnants of custom matrix from Skog rules.mk #7764

merged 1 commit into from
Jan 2, 2020

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jan 2, 2020

Description

I missed this in #7396. It should build now.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team January 2, 2020 19:33
ridingqwerty
ridingqwerty approved these changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was following the convo in #firmware; this looks good to me.

@zvecr zvecr merged commit 156d319 into qmk:master Jan 2, 2020
@fauxpark fauxpark deleted the skog-rules-fix branch January 2, 2020 19:51
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@fauxpark @HokieGeek
Remove remnants of custom matrix from Skog rules.mk (qmk#7764)
6595abf
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@fauxpark @kujawakk
Remove remnants of custom matrix from Skog rules.mk (qmk#7764)
81accce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@ridingqwerty ridingqwerty ridingqwerty approved these changes

Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @ridingqwerty @zvecr