Add LUFA mass storage BOOTLOADER "support"
#7729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty sure this would actually fix #1215 |
zvecr
approved these changes
Dec 29, 2019
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jan 2, 2020
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jan 6, 2020
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jan 8, 2020
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested with a Pro Micro and the MassStorage bootloader from current submodule LUFA. Mainly interested in the behaviour of the
RESETkeycode as it was reportedly not working (possiblyBOOTLOADER_SIZEwas wrong, sinceatmel-dfuspecifies 4kB instead of 6). It seems to work fine.I purposely did not document this, nor add it to the list in the templates. I will not be QMK-ifying the bootloader in our fork a la QMK-DFU. For anyone stumbling across this wanting to have a mass storage bootloader: I strongly advise against it 😄
Types of Changes
Issues Fixed or Closed by This PR
Checklist