Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Personal keymap for Let's Split keyboard. #7702

Merged
merged 27 commits into from
Jan 2, 2020
Merged

Personal keymap for Let's Split keyboard. #7702

merged 27 commits into from
Jan 2, 2020

Conversation

geripgeri
Copy link
Contributor

Description

This pull request contains my personal keymap for the Let's Split keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@geripgeri
Add Initial layout configuration.
01cdf4b
@geripgeri
Set arduino pro micro's built in RX LED as Numlock
0fa2725
@geripgeri
Enable Autoshift feautre.
ca58b2d
@geripgeri
Remove DVORAK layout.
163e9a7
@geripgeri
Add Numpad, update default layer.
eb49ab1
@geripgeri
Update AutoShift timeout.
2e68d0c
@geripgeri
Beautify ASCII Art.
54e4e21
@geripgeri
Update keymap.
b4eaa82
@geripgeri
Add Initial verison of RGB lighting.
793139f
@geripgeri
Add Tap dance, hungarian letters.
ab8e495 
.Xmodmap example: geripgeri/dotfiles@09f0587
@geripgeri
Update RGB to use only noeeprom functions.
3d62710
@geripgeri
Change default rgb led color.
dc7a799
@geripgeri
Merge remote-tracking branch 'upstream/master' into refactor
f36323f
@geripgeri
Add pragma once.
75214fa
@geripgeri
Merge pull request #1 from geripgeri/refactor
483e508 
Refactor
@geripgeri
Merge remote-tracking branch 'upstream/master'
e7b2e9e
@geripgeri
Emojis added.
54e7b1d
@geripgeri
Merge remote-tracking branch 'upstream/master'
31cf4b4
@geripgeri
Merge remote-tracking branch 'upstream/master'
afe509a
@geripgeri
Add tap dance for hungarian letters, multimedia control, slash/backsl…
ff877f1 
…ash.
@geripgeri
Remove audio related code.
0f41163
@geripgeri
Add Gaming layer.
30bccd5
@geripgeri
Remove unnecessary code, update copyright.
7d08af8
@geripgeri
Merge remote-tracking branch 'upstream/master'
56a625b
@geripgeri
Add readme.md
782594f
@geripgeri geripgeri marked this pull request as ready for review December 23, 2019 15:52
ridingqwerty
ridingqwerty approved these changes Dec 23, 2019
View reviewed changes
Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggestions on some improvements that could be made, but no glaring issues with this PR in my opinion.

keyboards/lets_split/keymaps/geripgeri/config.h Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/geripgeri/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/geripgeri/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/geripgeri/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/geripgeri/keymap.c Outdated Show resolved Hide resolved
@geripgeri
Copy link
Contributor Author

@ridingqwerty Thank you for your suggestions!
Cheers!

drashna
drashna reviewed Dec 25, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few more comments for cleanup and improvements, when you get a chance.

keyboards/lets_split/keymaps/geripgeri/config.h Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/geripgeri/config.h Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/geripgeri/config.h Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/geripgeri/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/geripgeri/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/geripgeri/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/geripgeri/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/geripgeri/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/geripgeri/keymap.c Outdated Show resolved Hide resolved
keyboards/lets_split/keymaps/geripgeri/keymap.c Outdated Show resolved Hide resolved
@geripgeri
Copy link
Contributor Author

@drashna Thank you for your suggestions!

drashna
drashna approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

Thanks!

@drashna drashna merged commit 2406c04 into qmk:master Jan 2, 2020
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@geripgeri @HokieGeek
[Keymap] Personal keymap for Let's Split keyboard. (qmk#7702)
54b6e3c 
* Add Initial layout configuration.

* Set arduino pro micro's built in RX LED as Numlock

* Enable Autoshift feautre.

* Remove DVORAK layout.

* Add Numpad, update default layer.

* Update AutoShift timeout.

* Beautify ASCII Art.

* Update keymap.

* Add Initial verison of RGB lighting.

* Add Tap dance, hungarian letters.

.Xmodmap example: geripgeri/dotfiles@09f0587

* Update RGB to use only noeeprom functions.

* Change default rgb led color.

* Add `pragma once`.

* Emojis added.

* Add tap dance for hungarian letters, multimedia control, slash/backslash.

* Remove audio related code.

* Add Gaming layer.

* Remove unnecessary code, update copyright.

* Add readme.md

* Implement code review suggestions.

* Implement code review suggestions qmk#2
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@geripgeri @kujawakk
[Keymap] Personal keymap for Let's Split keyboard. (qmk#7702)
329f725 
* Add Initial layout configuration.

* Set arduino pro micro's built in RX LED as Numlock

* Enable Autoshift feautre.

* Remove DVORAK layout.

* Add Numpad, update default layer.

* Update AutoShift timeout.

* Beautify ASCII Art.

* Update keymap.

* Add Initial verison of RGB lighting.

* Add Tap dance, hungarian letters.

.Xmodmap example: geripgeri/dotfiles@09f0587

* Update RGB to use only noeeprom functions.

* Change default rgb led color.

* Add `pragma once`.

* Emojis added.

* Add tap dance for hungarian letters, multimedia control, slash/backslash.

* Remove audio related code.

* Add Gaming layer.

* Remove unnecessary code, update copyright.

* Add readme.md

* Implement code review suggestions.

* Implement code review suggestions qmk#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ridingqwerty ridingqwerty ridingqwerty approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geripgeri @drashna @ridingqwerty