Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial user directory for milestogo + babblepaste #7698

Merged
merged 6 commits into from
May 9, 2020
Merged

initial user directory for milestogo + babblepaste #7698

merged 6 commits into from
May 9, 2020

Conversation

milestogo
Copy link
Contributor

Description

creating user directory for milestogo, merging in files that were originally in ms_sculpt_mobile. This is related to qmk_firmware/pull/7658

I've also cleaned up and improved the BabblePaste files.
BabblePaste is a universal translator for keyboard shortcuts.
The idea is to have one "paste" key do the right thing for any operating system.
Put the keyboard in Windows mode, and "paste" means Ctrl-v.
Switch to Emacs and "Paste" means Ctrl-y. Mac is GUI-v and so on.
The same key can jump to end of a line in VI or Emacs &etc.

I'd be interested in feedback on how to improve this & if it makes sense to draft it for a core feature instead of user space.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [X ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna reviewed Jan 2, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of things here, but otherwise, looks good

users/miles2go/rules.mk Outdated Show resolved Hide resolved
users/miles2go/keymaps/handwired/ms_sculpt_mobile/keymap.c Outdated Show resolved Hide resolved
users/miles2go/keymaps/handwired/ms_sculpt_mobile/keymap.c Outdated Show resolved Hide resolved
users/miles2go/keymaps/handwired/ms_sculpt_mobile/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team January 2, 2020 19:46
@drashna drashna added the keymap label Jan 2, 2020
@milestogo
fix includes per drashna and a few typos. I have not tested the users…
95932cd 
…pace keymap, it is just there to help keep the user space and keymap in sync
@stale
Copy link

stale bot commented Feb 18, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Feb 21, 2020
@drashna drashna requested a review from a team February 21, 2020 06:06
@NellyWhads
Copy link

Bumping this; is this still planned to merge to master?

@stale
Copy link

stale bot commented Apr 28, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Apr 29, 2020
@drashna drashna merged commit 803610a into qmk:master May 9, 2020
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@milestogo @lorenzoernesto
[Keymap] initial user directory for milestogo + babblepaste (qmk#7698)
f46eda1 
* initial user directory

* fix missing endif in vi mode

* fix includes per drashna and a few typos. I have not tested the userspace keymap, it is just there to help keep the user space and keymap in sync

* move babblepaste docs to md format

* clean up block quotes

* TIL clang-format - miles2go userspace
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@milestogo @sowbug
[Keymap] initial user directory for milestogo + babblepaste (qmk#7698)
edcaea7 
* initial user directory

* fix missing endif in vi mode

* fix includes per drashna and a few typos. I have not tested the userspace keymap, it is just there to help keep the user space and keymap in sync

* move babblepaste docs to md format

* clean up block quotes

* TIL clang-format - miles2go userspace
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@milestogo @turky
[Keymap] initial user directory for milestogo + babblepaste (qmk#7698)
32e8d02 
* initial user directory

* fix missing endif in vi mode

* fix includes per drashna and a few typos. I have not tested the userspace keymap, it is just there to help keep the user space and keymap in sync

* move babblepaste docs to md format

* clean up block quotes

* TIL clang-format - miles2go userspace
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@milestogo @jakobaa
[Keymap] initial user directory for milestogo + babblepaste (qmk#7698)
f2b63c7 
* initial user directory

* fix missing endif in vi mode

* fix includes per drashna and a few typos. I have not tested the userspace keymap, it is just there to help keep the user space and keymap in sync

* move babblepaste docs to md format

* clean up block quotes

* TIL clang-format - miles2go userspace
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@milestogo @sjmacneil
[Keymap] initial user directory for milestogo + babblepaste (qmk#7698)
900bbfe 
* initial user directory

* fix missing endif in vi mode

* fix includes per drashna and a few typos. I have not tested the userspace keymap, it is just there to help keep the user space and keymap in sync

* move babblepaste docs to md format

* clean up block quotes

* TIL clang-format - miles2go userspace
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@milestogo
[Keymap] initial user directory for milestogo + babblepaste (qmk#7698)
eb0eee5 
* initial user directory

* fix missing endif in vi mode

* fix includes per drashna and a few typos. I have not tested the userspace keymap, it is just there to help keep the user space and keymap in sync

* move babblepaste docs to md format

* clean up block quotes

* TIL clang-format - miles2go userspace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark left review comments

@Erovia Erovia Erovia approved these changes

@xplusplus xplusplus xplusplus approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
awaiting review keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@milestogo @NellyWhads @drashna @xplusplus @Erovia @fauxpark