Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update is31fl3731-simple #7610

Merged
merged 2 commits into from
Dec 6, 2020
Merged

Update is31fl3731-simple #7610

merged 2 commits into from
Dec 6, 2020

Conversation

Xelus22
Copy link
Contributor

@Xelus22 Xelus22 commented Dec 12, 2019

Update the current IS31FL3731-simple.c to reflect changes for more than 1 driver.
This is a draft as @drashna has advised as this is my first proper helpful PR.
Please critique anything that is wrong.
and tag @skullydazed 😄

Description

Changes code to reflect the number of drivers to update.

Update g_led_control_registers_update_required to false since it does not in the original code.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Use of more than 1 is31fl3731 driver when using the simple driver

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested review from skullydazed and a team December 12, 2019 19:49
@stale
Copy link

stale bot commented Jan 26, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@drashna drashna requested a review from a team February 5, 2020 04:00
@Xelus22 Xelus22 marked this pull request as ready for review October 11, 2020 08:37
@tzarc tzarc merged commit 6b1f96d into qmk:master Dec 6, 2020
xgnxs pushed a commit to xgnxs/qmk_firmware that referenced this pull request Jan 9, 2021
* update simple

* Update is31fl3731-simple.c
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 13, 2021
* update simple

* Update is31fl3731-simple.c
mgmanzella pushed a commit to mgmanzella/qmk_firmware that referenced this pull request Feb 16, 2021
* update simple

* Update is31fl3731-simple.c
@Xelus22 Xelus22 deleted the is31fl3731_simple branch June 2, 2021 11:39
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
* update simple

* Update is31fl3731-simple.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants