Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update firmware for Lily58 rev2 #7495

Closed
wants to merge 5 commits into from
Closed

Conversation

filoxo
Copy link
Contributor

@filoxo filoxo commented Nov 27, 2019

Description

Update firmware for Lily58 rev2. I moved stuff that was rev1 specific stuff into that folder, and modified the default keymap to support both revs.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Other

I'm aware of #6260 which might drastically change some of the supporting files (split_utils and such) which I don't think are essential for enabling RGB lighting.

@filoxo
Copy link
Contributor Author

filoxo commented Jun 10, 2020

Closing in favor of #8900

@filoxo filoxo closed this Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants