Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added csc027 keymaps for keebio/iris and planck #7472

Merged
merged 7 commits into from
Jan 3, 2020
Merged

Added csc027 keymaps for keebio/iris and planck #7472

merged 7 commits into from
Jan 3, 2020

Conversation

csc027
Copy link
Contributor

@csc027 csc027 commented Nov 24, 2019 •
edited
Loading

Description

Added csc027 user folder, as well as personal keymaps for the Iris and Planck keyboards.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@csc027 csc027 changed the title csc027/keymap Added csc027 keymaps for keebio/iris and planck Nov 26, 2019
@csc027
Copy link
Contributor Author

csc027 commented Nov 26, 2019 •
edited
Loading

Squashed commits, since there were too many, and renamed the PR to something more descriptive.

drashna
drashna reviewed Nov 26, 2019
View reviewed changes
users/csc027/csc027.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team November 26, 2019 07:25
@drashna drashna added the keymap label Nov 26, 2019
@drashna drashna requested a review from a team December 2, 2019 20:04
drashna
drashna reviewed Dec 5, 2019
View reviewed changes
users/csc027/usb_led.c Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Dec 17, 2019
View reviewed changes
keyboards/keebio/iris/keymaps/csc027/rules.mk Outdated Show resolved Hide resolved
users/csc027/defines.h Outdated Show resolved Hide resolved
users/csc027/defines.h Outdated Show resolved Hide resolved
users/csc027/csc027.c Outdated Show resolved Hide resolved
users/csc027/csc027.c Outdated Show resolved Hide resolved
users/csc027/csc027.c Outdated Show resolved Hide resolved
keyboards/planck/keymaps/csc027/rules.mk Outdated Show resolved Hide resolved
csc027 and others added 4 commits December 17, 2019 05:33
@csc027 @fauxpark
Update users/csc027/defines.h
8fd6023 
Removed the "_______" macro definition in defines.h, since it has already been defined in QMK.

Co-Authored-By: fauxpark <[email protected]>
@csc027 @fauxpark
Update users/csc027/defines.h
7d7d33f 
Removed the "XXXXXXX" macro definition in defines.h, since it has already been defined in QMK.

Co-Authored-By: fauxpark <[email protected]>
@csc027 @fauxpark
Update users/csc027/csc027.c
05d39a1 
Simplified several keyboard macro definitions in the csc027.c file by switching from SS_LCTRL to SS_LCTL in their definitions.

Co-Authored-By: fauxpark <[email protected]>
@csc027
Condensed both the planck and iris rules files to the minimal set of …
898f310 
…declarations.
@csc027 csc027 requested a review from fauxpark December 17, 2019 05:56
@drashna drashna requested a review from a team December 18, 2019 09:00
@csc027
Copy link
Contributor Author

csc027 commented Dec 19, 2019

Thanks @fauxpark and @drashna for taking the time to review the PR. :-)

noroadsleft
noroadsleft approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this didn't get merged, but I don't see anything of concern here.

Thanks!

@noroadsleft noroadsleft merged commit 2c14172 into qmk:master Jan 3, 2020
@csc027 csc027 deleted the csc027/keymap branch January 8, 2020 04:20
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@csc027 @HokieGeek
[Keymap] Added csc027 keymaps for keebio/iris and planck (qmk#7472)
621ec5d 
* Added csc027 user folder and keymaps for both keebio/iris and planck

* Moved the git_macros variable out of the process_record_user function.

* Updated the usb_led code to use the new led_update_user instead of the led_set_user function.

* Update users/csc027/defines.h

Removed the "_______" macro definition in defines.h, since it has already been defined in QMK.

* Update users/csc027/defines.h

Removed the "XXXXXXX" macro definition in defines.h, since it has already been defined in QMK.

* Update users/csc027/csc027.c

Simplified several keyboard macro definitions in the csc027.c file by switching from SS_LCTRL to SS_LCTL in their definitions.

* Condensed both the planck and iris rules files to the minimal set of declarations.
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@csc027 @kujawakk
[Keymap] Added csc027 keymaps for keebio/iris and planck (qmk#7472)
41d112f 
* Added csc027 user folder and keymaps for both keebio/iris and planck

* Moved the git_macros variable out of the process_record_user function.

* Updated the usb_led code to use the new led_update_user instead of the led_set_user function.

* Update users/csc027/defines.h

Removed the "_______" macro definition in defines.h, since it has already been defined in QMK.

* Update users/csc027/defines.h

Removed the "XXXXXXX" macro definition in defines.h, since it has already been defined in QMK.

* Update users/csc027/csc027.c

Simplified several keyboard macro definitions in the csc027.c file by switching from SS_LCTRL to SS_LCTL in their definitions.

* Condensed both the planck and iris rules files to the minimal set of declarations.
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@csc027 @noroadsleft
[Keymap] Added csc027 keymaps for keebio/iris and planck (qmk#7472)
7c14dd0 
* Added csc027 user folder and keymaps for both keebio/iris and planck

* Moved the git_macros variable out of the process_record_user function.

* Updated the usb_led code to use the new led_update_user instead of the led_set_user function.

* Update users/csc027/defines.h

Removed the "_______" macro definition in defines.h, since it has already been defined in QMK.

* Update users/csc027/defines.h

Removed the "XXXXXXX" macro definition in defines.h, since it has already been defined in QMK.

* Update users/csc027/csc027.c

Simplified several keyboard macro definitions in the csc027.c file by switching from SS_LCTRL to SS_LCTL in their definitions.

* Condensed both the planck and iris rules files to the minimal set of declarations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@csc027 @drashna @fauxpark @noroadsleft