[Keymap] Add DZ60, Levinson keymaps, twschum user files #7358

twschum · 2019-11-14T16:17:27Z

Description

Adds two keyboard layouts for the DZ60 from kbdfans using a split spacebar layout.
Adds Levinson (from keebio) layout that uses one half as a vertical numpad.
Adds custom functions in users/twschum

Types of Changes

Issues Fixed or Closed by This PR

N/A

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

…er key KC_NO

Co-Authored-By: Drashna Jaelre <[email protected]>

twschum · 2019-11-15T15:16:51Z

The lib/lufa changes should be resolved now

keyboards/dz60/keymaps/split_space_arrows/keymap.c

keyboards/dz60/keymaps/split_space_arrows/rules.mk

keyboards/dz60/keymaps/twschum_b_4_10/keymap.c

keyboards/dz60/keymaps/twschum_b_4_10/rules.mk

keyboards/dz60/rules.mk

keyboards/keebio/levinson/keymaps/numpad/keymap.c

noroadsleft

Looks good to me.

For future reference, we recommend against committing to your master branch as you've done here, because pull requests from modified master branches can make it more difficult to keep your QMK fork updated. It is highly recommended for QMK development – regardless of what is being done or where – to keep your master updated, but NEVER commit to it. Instead, do all your changes in a branch (branches are basically free in Git) and issue PRs from your branches when you're developing.

There are instructions on how to keep your fork updated here:

Best Practices: Your Fork's Master: Update Often, Commit Never

If you need any help with this just ask.

You do not need to close this pull request at this time. Until your pull request is merged, please continue to commit relevant changes to your master branch.

users/twschum/xtonhasvim.c

users/twschum/xtonhasvim.h

drashna

A lot of the tap/register code can be condensed more. I didn't flag every example, but I think you should get the jist of it from what I have.

It's optional, though. As is, it looks good, as is. Let us know if you'd like it merged as is, or if you'd like to further update it.

drashna · 2019-11-19T17:57:48Z

users/twschum/xtonhasvim.c

+      register_code(KC_LALT);
+        tap_code16(LSFT(KC_LEFT)); // select to start of this word
+      unregister_code(KC_LALT);


To further simplify this, I think you should be able to do this:

tap_code16(LALT(LSFT(KC_LEFT)));

Or even just:

tap_code16(A(S(KC_LEFT)));

drashna · 2019-11-19T17:58:24Z

users/twschum/xtonhasvim.c

+      register_code(KC_LALT);
+        tap_code16(LSFT(KC_RIGHT)); // select to end of this word
+      unregister_code(KC_LALT);


Same with above:

tap_code16(A(S(KC_RIGHT)));

drashna · 2019-11-19T17:59:31Z

users/twschum/xtonhasvim.c

+                register_code(KC_LSHIFT);
+                  tap_code16(LGUI(KC_RIGHT));
+                unregister_code(KC_LSHIFT);


Same as above:

tap_code16(S(G(KC_RIGHT)));

drashna · 2019-11-19T18:00:07Z

users/twschum/xtonhasvim.c

+              register_code(KC_LALT);
+              register_code(KC_LEFT);


You can do;

register_code16(A(KC_LEFT));

twschum · 2019-11-20T00:40:44Z

I think I'm fine with it fine as-is. There's still some other changes I want to do with all this code anyways and probably best handled in a new branch/PR.

Thanks for the prompt and thorough reviews!

* Adds layout for DZ60rev2 plate B, options 4 and 10 * Use KC_TRANS for layer keys * Format layer0 with visual key size layout * Add RGB controls; add start description; add KC_LOCK * Update comments on rules.mk for DZ60 * Gets keymap compiling * Fix wiring for shift on row 3 * Hold a with other key to send Ctrl-A before other key * Adds compile-time defined mac-compatability media keycodes * Adds logic in place for capturing taps (w/ timeout) * Add send_keys(...) which can send up to 64 nested keycodes * Implement send_keys callable with n repeats * Tweaks some of the keymap * Add reset keycode; add disable to custom shortcuts * Adds a special "off" layer where bonus mod goes to layer 0, every other key KC_NO * Adjust timeout; mousekey settings * Changes layout of Home,End,PgUp/Dn on the dedicated arrow keys L1/L2 * PoC on rgb lighted layer indication * Refactors color table defines * Adds logic for controlling layer lights * Only change state on one side of the event lol * Switch back to Tapping Toggle for layer 4 * Add custom config file for keyboard; TT and mousekey settings * Code cleanup; starting to refactor special ctrl tapping keys functions * Move defines and �reak out functions * Remove debugging light * Adjust keymaps; add enter * Adds a couple custom macros * Add simplified version of keymap to help debug issues * Adds basi numpad configuration for levinson keyboard half * Use ANSI ctrl key as layer 1 for better one hand (`) * Adapt to new 8bit hue from qmk#5547; layer enum use everywhere * Move custom code out to users/ space * Flip col pins, move key assignments to "left hand" * Update readme * Implement placeholder macros * Notes * Reduce tapping time for SFT_T(/) * Adds vim features; refactors things * Adds fork of the vim features written by xton * Use correct backspace keycode * Add VIM_ESC * Add "OFF" to the RGB/HSV definitions * Clean up rules, use new "OFF" definition * Add windows KC_CALCULATOR key to numpad * Reformat layers with better guide; change layer names * Add sleep key * Change timeout delay * Add a "code paste" which surrounds a ^V with ``` * Try removing shift tap on rshift / * Update macros * Update the "code paste" macro * Update keymap with reset, calc, equals * Update keyboards/dz60/keymaps/twschum_b_4_10_simple/keymap.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/dz60/keymaps/twschum_b_4_10/keymap.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update users/twschum/twschum.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update users/twschum/twschum.c Co-Authored-By: Drashna Jaelre <[email protected]> * Revert quantum/rgblight_list.h * Better name for split space layout; rename KEYMAP->LAYOUT * Rename KEYMAP->LAYOUT * Use simpler :flash command * Clean up layout files * Use qmk's MOD_MASK_CTRL * Sync lufa submodule * Cleanup from noroadsleft's PR comments * Modernize vim layer code

twschum added 30 commits May 1, 2018 09:56

Adds layout for DZ60rev2 plate B, options 4 and 10

8112f3c

Use KC_TRANS for layer keys

9db53df

Format layer0 with visual key size layout

525a5d8

Add RGB controls; add start description; add KC_LOCK

ba1b077

Update comments on rules.mk for DZ60

cb27a2b

Gets keymap compiling

d994b22

Fix wiring for shift on row 3

d2d72fc

Hold a with other key to send Ctrl-A before other key

169a1f7

Adds compile-time defined mac-compatability media keycodes

70c1d51

Adds logic in place for capturing taps (w/ timeout)

a4a22cd

Add send_keys(...) which can send up to 64 nested keycodes

358cad4

Implement send_keys callable with n repeats

f5c669d

Tweaks some of the keymap

0b206e4

Add reset keycode; add disable to custom shortcuts

d3952e8

Adds a special "off" layer where bonus mod goes to layer 0, every oth…

227f52a

…er key KC_NO

Adjust timeout; mousekey settings

201a316

Changes layout of Home,End,PgUp/Dn on the dedicated arrow keys L1/L2

5a4bcd9

PoC on rgb lighted layer indication

06300a3

Refactors color table defines

7890496

Adds logic for controlling layer lights

6f8802b

Only change state on one side of the event lol

4de7b4a

Switch back to Tapping Toggle for layer 4

4f249e4

Add custom config file for keyboard; TT and mousekey settings

4cdec9a

Code cleanup; starting to refactor special ctrl tapping keys functions

c2d60bb

Move defines and �reak out functions

87b8c36

Remove debugging light

23ed978

Adjust keymaps; add enter

56030b3

Adds a couple custom macros

d13773a

Add simplified version of keymap to help debug issues

1934346

Merge tag '0.6.397' of https://github.com/qmk/qmk_firmware

06a0f2f

twschum and others added 4 commits November 15, 2019 10:13

Update keyboards/dz60/keymaps/twschum_b_4_10_simple/keymap.c

15cf63a

Co-Authored-By: Drashna Jaelre <[email protected]>

Update keyboards/dz60/keymaps/twschum_b_4_10/keymap.c

7d4edfc

Co-Authored-By: Drashna Jaelre <[email protected]>

Update users/twschum/twschum.c

b8ad17d

Co-Authored-By: Drashna Jaelre <[email protected]>

Update users/twschum/twschum.c

144ace9

Co-Authored-By: Drashna Jaelre <[email protected]>

twschum added 7 commits November 15, 2019 10:48

Revert quantum/rgblight_list.h

c1c9ea2

Better name for split space layout; rename KEYMAP->LAYOUT

a059c56

Rename KEYMAP->LAYOUT

f948ff3

Use simpler :flash command

1e6fd79

Clean up layout files

4f62992

Use qmk's MOD_MASK_CTRL

9bf88ee

Sync lufa submodule

2527ebc

noroadsleft requested changes Nov 15, 2019

View reviewed changes

Cleanup from noroadsleft's PR comments

cea19f9

noroadsleft approved these changes Nov 16, 2019

View reviewed changes

drashna reviewed Nov 16, 2019

View reviewed changes

users/twschum/xtonhasvim.c Outdated Show resolved Hide resolved

drashna reviewed Nov 16, 2019

View reviewed changes

users/twschum/xtonhasvim.h Outdated Show resolved Hide resolved

drashna reviewed Nov 16, 2019

View reviewed changes

users/twschum/xtonhasvim.h Outdated Show resolved Hide resolved

Modernize vim layer code

5e81575

drashna reviewed Nov 19, 2019

View reviewed changes

drashna approved these changes Nov 21, 2019

View reviewed changes

drashna merged commit 84065e1 into qmk:master Nov 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Keymap] Add DZ60, Levinson keymaps, twschum user files #7358

[Keymap] Add DZ60, Levinson keymaps, twschum user files #7358

twschum commented Nov 14, 2019 •

edited

Loading

twschum commented Nov 15, 2019 •

edited

Loading

noroadsleft left a comment

drashna left a comment

drashna Nov 19, 2019

drashna Nov 19, 2019

drashna Nov 19, 2019

drashna Nov 19, 2019

twschum commented Nov 20, 2019 •

edited

Loading

[Keymap] Add DZ60, Levinson keymaps, twschum user files #7358

[Keymap] Add DZ60, Levinson keymaps, twschum user files #7358

Conversation

twschum commented Nov 14, 2019 • edited Loading

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

twschum commented Nov 15, 2019 • edited Loading

noroadsleft left a comment

Choose a reason for hiding this comment

drashna left a comment

Choose a reason for hiding this comment

drashna Nov 19, 2019

Choose a reason for hiding this comment

drashna Nov 19, 2019

Choose a reason for hiding this comment

drashna Nov 19, 2019

Choose a reason for hiding this comment

drashna Nov 19, 2019

Choose a reason for hiding this comment

twschum commented Nov 20, 2019 • edited Loading

twschum commented Nov 14, 2019 •

edited

Loading

twschum commented Nov 15, 2019 •

edited

Loading

twschum commented Nov 20, 2019 •

edited

Loading