Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set git submodule update depth to 50 #7269

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Set git submodule update depth to 50 #7269

merged 1 commit into from
Nov 5, 2019

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Nov 5, 2019

Description

Per https://superuser.com/a/1286550, the depth being set to 1 seems to be what's causing some of the submodule headaches - at least for LUFA. 50 is the value that Travis uses to clone, so let's go with that.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added the bug label Nov 5, 2019
@fauxpark fauxpark requested a review from a team November 5, 2019 13:04
@drashna drashna merged commit 7c0edbe into qmk:master Nov 5, 2019
@fauxpark fauxpark deleted the submodule-depth branch November 5, 2019 21:35
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Nov 17, 2019
@fauxpark @drashna
Set git submodule update depth to 50 (qmk#7269)
e1e89d0
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@fauxpark
Set git submodule update depth to 50 (qmk#7269)
0782b57
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@fauxpark @patrl
Set git submodule update depth to 50 (qmk#7269)
005fc7c
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 6, 2020
@fauxpark @fdidron
Set git submodule update depth to 50 (qmk#7269)
a05e09b
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 8, 2020
@fauxpark @fdidron
Set git submodule update depth to 50 (qmk#7269)
4c1bdea
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@fauxpark @HokieGeek
Set git submodule update depth to 50 (qmk#7269)
e213db9
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark @drashna
Set git submodule update depth to 50 (qmk#7269)
9b574ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @zvecr