Added 4by3 keyboard

[eliassjogreen]

Description

Added the 4by3 keypad, a small macro pad using the pro micro.

Also added a few different keymaps to the keypad:

• arrow_pad
• default
• function_horizontal
• function_vertical_left
• function_vertical_right
• numpad_horizontal
• numpad_vertical_left
• numpad_vertical_right

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Issues Fixed or Closed by This PR

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes (or in this case the keyboard) and verified that they work and don't break anything (as well as I can manage).

[drashna]

This looks good, for the most part.

My only issue here, is that we generally denote row by column, not column by row.

So, it would be 3x4, not 4x3.

If you look at the default layouts, you'll see this, as well.

It's a minor thing, but it bugs me.

[noroadsleft]

This looks good, for the most part.

My only issue here, is that we generally denote row by column, not column by row.

So, it would be 3x4, not 4x3.

If you look at the default layouts, you'll see this, as well.

It's a minor thing, but it bugs me.

It bugs me too. Not only that, the image on the readme says "3by4."

[noroadsleft]

I'm also not keen on how the layout macro and keymaps are.

• Keymaps arrow_pad and default are identical.
  In this case I'd remove arrow_pad and put a readme on default.
• Keymaps function_vertical_left and function_vertical_right are functionally identical.
  The only difference seems to be the direction the user sets the board (whether the Pro Micro is to the right, facing up; or to the left, facing down). I think the layout macro is a better way to solve this. The keymap should always resemble the physical orientation with respect to the user, IMO.
• Keymaps numpad_vertical_left and numpad_vertical_right are functionally identical in the same way.

[eliassjogreen]

This looks good, for the most part.
My only issue here, is that we generally denote row by column, not column by row.
So, it would be 3x4, not 4x3.
If you look at the default layouts, you'll see this, as well.
It's a minor thing, but it bugs me.

It bugs me too. Not only that, the image on the readme says "3by4."

The PCB shown in the readme was is only a prototype and the text saying 3by4 was only a typo which has been fixed.

Working on fixing all of the requested changes :).

[eliassjogreen]

Also it is not possible to have the macro resemble the physical orientation due to the fact you can only have as many rows as defined in config.h without getting the excess elements in array initializer error.

[drashna]

@eliassjogreen that's true for the physical matrix, but the LAYOUT macro allows you to remap that matrix to ANYTHING.

For instance, the Planck rev6 is a 4x12 ortho board, but the physical matrix is actually 6x8.

https://github.com/qmk/qmk_firmware/blob/master/keyboards/planck/rev6/rev6.h#L89-L104

So, the bottom half is what the physical matrix is, while the is literally any way you want it.

But either way, the board is a 3x4, not a 4x3 . (3 rows, 4 columns).

[eliassjogreen]

Thanks! Got it the otherway around when i got the excess elements in array initializer but now it works fine :D

I also believe i fixed the following issues:

I'm also not keen on how the layout macro and keymaps are.

* Keymaps `arrow_pad` and `default` are identical.
  In this case I'd remove `arrow_pad` and put a readme on `default`.

* Keymaps `function_vertical_left` and `function_vertical_right` are functionally identical.
  The only difference seems to be the direction the user sets the board (whether the Pro Micro is to the right, facing up; or to the left, facing down). I think the layout macro is a better way to solve this. The keymap should always resemble the physical orientation with respect to the user, IMO.

* Keymaps `numpad_vertical_left` and `numpad_vertical_right` are functionally identical in the same way.

[noroadsleft]

Thanks!