Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config option for DIRECT_PINS_RIGHT #6479

Merged
merged 1 commit into from
Aug 4, 2019
Merged

Add config option for DIRECT_PINS_RIGHT #6479

merged 1 commit into from
Aug 4, 2019

Conversation

gesinger
Copy link
Contributor

@gesinger gesinger commented Aug 3, 2019

Adds support for different direct pin mappings on the halves of a split keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project. (followed indentation of MATRIX_ROW_PINS_RIGHT and MATRIX_COLS_PINS_RIGHT blocks)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage). (tested on one keyboard, have not tested much for regressions or otherwise)

@gesinger
Add config option for DIRECT_PINS_RIGHT
3b692f6 
Adds support for different direct pin mappings on the halves of a split keyboard.
@zvecr zvecr requested a review from a team August 3, 2019 21:41
@zvecr zvecr added the core label Aug 3, 2019
drashna
drashna approved these changes Aug 4, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds feature parity to the split keyboard common code, I like it!

@drashna drashna merged commit f644db0 into qmk:master Aug 4, 2019
@gesinger
Copy link
Contributor Author

gesinger commented Aug 4, 2019

Thanks @zvecr for all of the help (here and on Discord). And thank you @drashna .

Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Aug 6, 2019
@Shinichi-Ohki
Merge branch 'master' of https://github.com/qmk/qmk_firmware
ce8d771 
* 'master' of https://github.com/qmk/qmk_firmware: (240 commits)
  Move maartenwut's keyboards to one folder (qmk#6484)
  GH60 Refactor: Move Satan into GH60 directory (qmk#6485)
  Remove unused _BOOTLOADER defines
  [Keyboard] add keyboard-discipline (qmk#6464)
  [Split] Add config option for DIRECT_PINS_RIGHT (qmk#6479)
  [Keymap] Add some more commonly used symbols to melody96/zunger. (qmk#6478)
  [Keyboard] WT75-A & WT75-B fixes for QMK Configurator (qmk#6472)
  [Keymap] update to dsanchezseco keymap (qmk#6470)
  [Keymap] Fixed Tanuki RGB lighting (qmk#6462)
  Add iS0 Keypad (qmk#6456)
  [Keymap] jotix ortho_4x12_layout (qmk#6458)
  [Keyboard] New Keyboard: KBDPad MKI (qmk#6452)
  [Keymap] Adds Keymap for Iris/blucky (qmk#6449)
  [Keymap] Fixing Sol Rev2 default keymap OLED rotation. (qmk#6448)
  [Keyboard] QWERTYYdox refactor (qmk#6446)
  [Keymap] Adds keymap for muzfuz/lunar (qmk#6432)
  [Docs] Add dfu-util and caterina udev examples (qmk#6429)
  updates to akb/raine in ready for production units (qmk#6457)
  Removed print call to resolve  qmk#6364 (qmk#6413)
  Fix typo for building Ergodox EZ keyboards (qmk#6453)
  ...
Acaki pushed a commit to Acaki/qmk_firmware that referenced this pull request Aug 6, 2019
@gesinger
[Split] Add config option for DIRECT_PINS_RIGHT (qmk#6479)
652a68d 
Adds support for different direct pin mappings on the halves of a split keyboard.
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Aug 8, 2019
@gesinger @drashna
[Split] Add config option for DIRECT_PINS_RIGHT (qmk#6479)
d864cca 
Adds support for different direct pin mappings on the halves of a split keyboard.
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Aug 13, 2019
@gesinger @fdidron
[Split] Add config option for DIRECT_PINS_RIGHT (qmk#6479)
31b5a5c 
Adds support for different direct pin mappings on the halves of a split keyboard.
incredibleweirdo pushed a commit to electricbrainreserve/qmk_firmware that referenced this pull request Aug 15, 2019
@gesinger @incredibleweirdo
[Split] Add config option for DIRECT_PINS_RIGHT (qmk#6479)
4b00632 
Adds support for different direct pin mappings on the halves of a split keyboard.
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
@gesinger @doughsay
[Split] Add config option for DIRECT_PINS_RIGHT (qmk#6479)
2e674e1 
Adds support for different direct pin mappings on the halves of a split keyboard.
swanmatch pushed a commit to swanmatch/qmk_firmware that referenced this pull request Sep 3, 2019
@gesinger @drashna
[Split] Add config option for DIRECT_PINS_RIGHT (qmk#6479)
2df1ccb 
Adds support for different direct pin mappings on the halves of a split keyboard.
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@gesinger
[Split] Add config option for DIRECT_PINS_RIGHT (qmk#6479)
e634a93 
Adds support for different direct pin mappings on the halves of a split keyboard.
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@gesinger @drashna
[Split] Add config option for DIRECT_PINS_RIGHT (qmk#6479)
5f4cd36 
Adds support for different direct pin mappings on the halves of a split keyboard.
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@gesinger @drashna
[Split] Add config option for DIRECT_PINS_RIGHT (qmk#6479)
15f6957 
Adds support for different direct pin mappings on the halves of a split keyboard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gesinger @drashna @zvecr