Add support for XD004 macro keyboard #6337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Force-pushed to include my actual email address, sorry about that. |
drashna
reviewed
Jul 15, 2019
| const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | ||
|
|
||
| // 0: Base Layer | ||
| LAYOUT_all(KC_L, KC_O, KC_V, KC_E), |
There was a problem hiding this comment.
That's actually the default layout it shipped with. Mechanical keyboards, spreading the love 😄
drashna
requested changes
Jul 15, 2019
fauxpark
requested changes
Jul 15, 2019
Also applying the following suggested edits: Add hardware availability link in readme Co-Authored-By: Drashna Jaelre <[email protected]> Enable lite bootmagic Co-Authored-By: Drashna Jaelre <[email protected]> Remove commented out MCU Co-Authored-By: fauxpark <[email protected]>
Correcting usage of tap_code_16 for modified key, thanks to @drashna
Co-Authored-By: Drashna Jaelre <[email protected]>
drashna
approved these changes
Jul 15, 2019
|
Thanks! |
doughsay
pushed a commit
to doughsay/qmk_firmware
that referenced
this pull request
Aug 31, 2019
* Add support for XD004 Also applying the following suggested edits: Add hardware availability link in readme Co-Authored-By: Drashna Jaelre <[email protected]> Enable lite bootmagic Co-Authored-By: Drashna Jaelre <[email protected]> Remove commented out MCU Co-Authored-By: fauxpark <[email protected]> * Add more ellaborate keymap Correcting usage of tap_code_16 for modified key, thanks to @drashna * Add information about bootloader type Co-Authored-By: Drashna Jaelre <[email protected]>
swanmatch
pushed a commit
to swanmatch/qmk_firmware
that referenced
this pull request
Sep 3, 2019
* Add support for XD004 Also applying the following suggested edits: Add hardware availability link in readme Co-Authored-By: Drashna Jaelre <[email protected]> Enable lite bootmagic Co-Authored-By: Drashna Jaelre <[email protected]> Remove commented out MCU Co-Authored-By: fauxpark <[email protected]> * Add more ellaborate keymap Correcting usage of tap_code_16 for modified key, thanks to @drashna * Add information about bootloader type Co-Authored-By: Drashna Jaelre <[email protected]>
ripxorip
pushed a commit
to ripxorip/qmk_firmware
that referenced
this pull request
Dec 3, 2019
* Add support for XD004 Also applying the following suggested edits: Add hardware availability link in readme Co-Authored-By: Drashna Jaelre <[email protected]> Enable lite bootmagic Co-Authored-By: Drashna Jaelre <[email protected]> Remove commented out MCU Co-Authored-By: fauxpark <[email protected]> * Add more ellaborate keymap Correcting usage of tap_code_16 for modified key, thanks to @drashna * Add information about bootloader type Co-Authored-By: Drashna Jaelre <[email protected]>
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
* Add support for XD004 Also applying the following suggested edits: Add hardware availability link in readme Co-Authored-By: Drashna Jaelre <[email protected]> Enable lite bootmagic Co-Authored-By: Drashna Jaelre <[email protected]> Remove commented out MCU Co-Authored-By: fauxpark <[email protected]> * Add more ellaborate keymap Correcting usage of tap_code_16 for modified key, thanks to @drashna * Add information about bootloader type Co-Authored-By: Drashna Jaelre <[email protected]>
swamp09
pushed a commit
to swamp09/qmk_firmware
that referenced
this pull request
Mar 11, 2020
* Add support for XD004 Also applying the following suggested edits: Add hardware availability link in readme Co-Authored-By: Drashna Jaelre <[email protected]> Enable lite bootmagic Co-Authored-By: Drashna Jaelre <[email protected]> Remove commented out MCU Co-Authored-By: fauxpark <[email protected]> * Add more ellaborate keymap Correcting usage of tap_code_16 for modified key, thanks to @drashna * Add information about bootloader type Co-Authored-By: Drashna Jaelre <[email protected]>
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
* Add support for XD004 Also applying the following suggested edits: Add hardware availability link in readme Co-Authored-By: Drashna Jaelre <[email protected]> Enable lite bootmagic Co-Authored-By: Drashna Jaelre <[email protected]> Remove commented out MCU Co-Authored-By: fauxpark <[email protected]> * Add more ellaborate keymap Correcting usage of tap_code_16 for modified key, thanks to @drashna * Add information about bootloader type Co-Authored-By: Drashna Jaelre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default TMK firmware for this board seems to favor underglow lighting instead of tap or oneshot actions. This is why this pull request proposes an alternative to fit on the small flash size (12KB) a firmware that does tapping and oneshot and has no RGB lighting support.
Types of Changes
Issues Fixed or Closed by This PR
Checklist
The only warning I get when building is that the firmware just fits in the flash, which I assume can't be helped and is ok: