bface refactor #6333
Merged
bface refactor #6333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
reviewed
Jul 15, 2019
| writePinHigh(D6); | ||
| } | ||
|
|
||
| void backlight_set(uint8_t level) { |
There was a problem hiding this comment.
The Backlight feature supports defining multiple pins in software (with hardware timer) PWM mode: https://docs.qmk.fm/#/feature_backlight?id=multiple-backlight-pins
Though it is apparently experimental, might be worth a try. Apart from D4, the other three pins here are not hardware PWM capable anyway on the 32A.
There was a problem hiding this comment.
I really hope people stop making BMC compatible boards. Old boards I can understand but new ones, not so much.
drashna
approved these changes
Jul 15, 2019
swanmatch
pushed a commit
to swanmatch/qmk_firmware
that referenced
this pull request
Sep 3, 2019
* remove custom matrix support * remove custom i2c and led driver * minor cleanups * update readme
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
* remove custom matrix support * remove custom i2c and led driver * minor cleanups * update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored the b.face to remove custom i2c and custom matrix.
Types of Changes
Checklist