Made it possible for real to choose register on io expander for cols and rows #6124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErinCall
approved these changes
Jun 13, 2019
| @@ -36,7 +36,8 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. | |||
| #define COL_EXPANDED { true, true, true, true, true, true, false, false, false, false, false, false} | |||
| #define MATRIX_ONBOARD_ROW_PINS { F0, F1, F4, F5, F6, F7 } | |||
| #define MATRIX_ONBOARD_COL_PINS { 0, 0, 0, 0, 0, 0, B1, B2, B3, D2, D3, C6 } | |||
| #define EXPANDER_COL_REGISTER 0 | |||
| #define EXPANDER_COL_REGISTER GPIOA | |||
| +-------+---------------+---------------+ | ||
| */ | ||
|
|
||
| #if (EXPANDER_COLUMN_REGISTER == 0) | ||
| #if (EXPANDER_COL_REGISTER == GPIOA) |
There was a problem hiding this comment.
Geez, I really wrote half of this feature and committed it without any testing, huh?
There was a problem hiding this comment.
I guess so :) Apart from this little typo, you've done a great job and it's a joy working with an expander thanks to your code! To be honest I haven't done any serious testing with the cols on A and rows on B, but in theory it should work.
8 tasks
|
Oh man, this is close to be merged into core.... |
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
…r for cols and rows (qmk#6124) * Replace deprecated EXPANDER_MASK with dynamic expander_pin_input_mask * Made it possible to switch rows and cols registers on expander
doughsay
pushed a commit
to doughsay/qmk_firmware
that referenced
this pull request
Aug 31, 2019
…r for cols and rows (qmk#6124) * Replace deprecated EXPANDER_MASK with dynamic expander_pin_input_mask * Made it possible to switch rows and cols registers on expander
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
…r for cols and rows (qmk#6124) * Replace deprecated EXPANDER_MASK with dynamic expander_pin_input_mask * Made it possible to switch rows and cols registers on expander
JeffreyPalmer
pushed a commit
to JeffreyPalmer/qmk_firmware
that referenced
this pull request
Feb 27, 2020
…r for cols and rows (qmk#6124) * Replace deprecated EXPANDER_MASK with dynamic expander_pin_input_mask * Made it possible to switch rows and cols registers on expander
swamp09
pushed a commit
to swamp09/qmk_firmware
that referenced
this pull request
Mar 11, 2020
…r for cols and rows (qmk#6124) * Replace deprecated EXPANDER_MASK with dynamic expander_pin_input_mask * Made it possible to switch rows and cols registers on expander
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@ErinCall has made a huge effort to generalize matrix.c for io expander keyboards in #2065. When I tried to put the columns on register B on the io expander I just couldn't get it to work, so I dug into the code. This pretty simple fix solves the issues I faced, and IMHO brings a little bit more clarity to what's going on.
Types of Changes
Issues Fixed or Closed by This PR
Checklist