Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new planck keymap #6122

Merged
merged 2 commits into from Jun 13, 2019
Merged

add new planck keymap #6122

merged 2 commits into from Jun 13, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 12, 2019

Description

add a new planck keymap with rotary encoder scroll and media functionality

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

noroadsleft
noroadsleft approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

drashna
drashna approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@drashna drashna merged commit 03ce370 into qmk:master Jun 13, 2019
@ghost ghost deleted the planck_keymaps branch June 14, 2019 05:01
@ghost ghost restored the planck_keymaps branch June 14, 2019 05:03
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@Timbus
[Keymap] add new planck keymap (qmk#6122)
b9692e9 
* add new planck keymap

* add newlines to end of files
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
@doughsay
[Keymap] add new planck keymap (qmk#6122)
5184a57 
* add new planck keymap

* add newlines to end of files
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@drashna
[Keymap] add new planck keymap (qmk#6122)
70530b9 
* add new planck keymap

* add newlines to end of files
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
@JeffreyPalmer
[Keymap] add new planck keymap (qmk#6122)
30b24b5 
* add new planck keymap

* add newlines to end of files
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
@swamp09
[Keymap] add new planck keymap (qmk#6122)
c65b77c 
* add new planck keymap

* add newlines to end of files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drashna @noroadsleft