Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

niu_mini uses dfu bootloader rather than the afrdude bootloader #6092

Merged
merged 2 commits into from
Jun 9, 2019

Conversation

hadibus
Copy link
Contributor

@hadibus hadibus commented Jun 7, 2019

modified: readme.md

Description

Small change to the readme. The afrdude bootloader doesn't work for the niu_mini. The dfu bootloader does work for the niu_mini.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes. Not Applicable
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zvecr
Copy link
Member

zvecr commented Jun 7, 2019

Should the rules.mk also be updated from the older OPT_DEFS += -DBOOTLOADER_SIZE=4096 to BOOTLOADER = atmel-dfu?

@drashna
Copy link
Member

drashna commented Jun 7, 2019

Should the rules.mk also be updated from the older OPT_DEFS += -DBOOTLOADER_SIZE=4096 to BOOTLOADER = atmel-dfu?

Yes, 100%. @hadibus if you could update that too?

	modified:   keyboards/niu_mini/rules.mk
@hadibus
Copy link
Contributor Author

hadibus commented Jun 8, 2019

@drashna Yes. I wonder if the comments above that line I changed in rules.mk should be updated as well. I'm new to this project.

@drashna
Copy link
Member

drashna commented Jun 8, 2019

Nah, they're fine.

And they're documented, technically: https://docs.qmk.fm/#/config_options?id=avr-mcu-options

@drashna
Copy link
Member

drashna commented Jun 8, 2019

Thanks!

@drashna drashna merged commit 8ac9048 into qmk:master Jun 9, 2019
@hadibus hadibus deleted the niu_mini_uses_dfu branch June 10, 2019 01:47
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
…oader (qmk#6092)

* niu_mini uses dfu bootloader rather than the afrdude bootloader
	modified: readme.md

* Change rules in rules.mk to reflect the bootloader change
	modified:   keyboards/niu_mini/rules.mk
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
…oader (qmk#6092)

* niu_mini uses dfu bootloader rather than the afrdude bootloader
	modified: readme.md

* Change rules in rules.mk to reflect the bootloader change
	modified:   keyboards/niu_mini/rules.mk
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
…oader (qmk#6092)

* niu_mini uses dfu bootloader rather than the afrdude bootloader
	modified: readme.md

* Change rules in rules.mk to reflect the bootloader change
	modified:   keyboards/niu_mini/rules.mk
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
…oader (qmk#6092)

* niu_mini uses dfu bootloader rather than the afrdude bootloader
	modified: readme.md

* Change rules in rules.mk to reflect the bootloader change
	modified:   keyboards/niu_mini/rules.mk
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
…oader (qmk#6092)

* niu_mini uses dfu bootloader rather than the afrdude bootloader
	modified: readme.md

* Change rules in rules.mk to reflect the bootloader change
	modified:   keyboards/niu_mini/rules.mk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Niu Mini uses dfu bootloader, the suggested command is wrong
5 participants