Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Update Corne Keyboard to updated Helix split code #5999

Closed
wants to merge 2 commits into from

Conversation

drashna
Copy link
Member

@drashna drashna commented May 27, 2019

Description

Updates the Corne Keyboard to use the updated Helix type split code (mostly).

Also, this cleans up a bunch of the keymaps.
Removes both the OLED code and LAYOUT_kc from the default keymap, and creates an OLED keymap that uses the OLED_DRIVER feature, which actually supports rotating the display (so it's actually readable)

Just to make sure I have the OK's here, since I touched your code:
@foostan @epaew @JarredSteenvoorden @marksard @OMGVee @rs @the-frey

Also, I think I may update this to use Split Common instead, too.

This breaks the RGB Matrix feature completely, until the code is rewritten to support it.

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna changed the title Keyboard/update crkbd [Keyboard] Update Corne Keyboard to updated Helix split code May 27, 2019
Copy link
Contributor

@OMGVee OMGVee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for my keymap after cherrypicking. Thanks @drashna , you rock dude!

@the-frey
Copy link
Contributor

Looks good from a glance at the code. I'll try it out ASAP.

Copy link
Contributor

@marksard marksard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll try it out ASAP.

@drashna
Copy link
Member Author

drashna commented Jun 11, 2019

Well, testing with #6001 and #5998 gives a better experience, with little or no change in behavior. So I think we want to go with that change, instead.

@drashna drashna closed this Jun 17, 2019
@drashna drashna deleted the keyboard/update_crkbd branch October 31, 2019 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants