[Keyboard] Update Corne Keyboard to updated Helix split code #5999
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the Corne Keyboard to use the updated Helix type split code (mostly).
Also, this cleans up a bunch of the keymaps.
Removes both the OLED code and
LAYOUT_kc
from the default keymap, and creates an OLED keymap that uses theOLED_DRIVER
feature, which actually supports rotating the display (so it's actually readable)Just to make sure I have the OK's here, since I touched your code:
@foostan @epaew @JarredSteenvoorden @marksard @OMGVee @rs @the-frey
Also, I think I may update this to use Split Common instead, too.
This breaks the RGB Matrix feature completely, until the code is rewritten to support it.
Types of Changes
Issues Fixed or Closed by This PR
Checklist