Makefile: Keep going when building with make -k #582
Conversation
|
Still working on this one, there are some issues to iron out. The next push should make it behave properly... |
Instead of failing early on the first error, when building with `make -k`, keep going until the end, and only fail the build then. Signed-off-by: Gergely Nagy <[email protected]>
|
This last one should do. Worked locally. There may be build failures nevertheless.. at least I've seen some when building on my laptop, but I doubt those are the results of this change. |
|
Yeah, CI bombs on this one for some reason, so not merging for now. You think the errors are not related to this branch? |
|
Not sure. I see |
|
I gave this another go, and came to the conclusion that doing this would be a huge pain, unless the makefile system gets a big overhaul, to make things like this easier. The problem is, that the keymaps and keyboards are built in a for loop, and make gets called recursively many times, and the exit status would need to be bubbled up. That's ugh... A better way would be to use dependencies, such that This would require a major overhaul of the build system, and I'm not prepared for that at the moment. If anyone finds a way to only fail at the very end, and still keep the current fail-early behaviour as an option, without sacrificing many goats to the gods of Make, please let me know. Closing the PR, because I'm not able to make it work with the resources I have. |
* Add default keymaps for Zinc revs. 1 and A * Add default keymap for ZJ68
* Add Vial support to Keebio Sinc keyboard * Move Vial keymap to rev4 specifically * Remove unnecessary layer
Instead of failing early on the first error, when building with
make -k, keep going until the end, and only fail the build then.