Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX rgblight.c split sync bug #5694

Merged
merged 2 commits into from
Apr 24, 2019
Merged

FIX rgblight.c split sync bug #5694

merged 2 commits into from
Apr 24, 2019

Conversation

mtei
Copy link
Contributor

@mtei mtei commented Apr 23, 2019 •
edited
Loading

Description

Fixed that sync information was not notified to slave when rgblight_update_dword() and eeconfig_update_rgblight_default() were executed.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mtei mtei mentioned this pull request Apr 23, 2019
Merged
13 tasks
drashna
drashna approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my end, seems to ... at least not cause any issues.

@mtei
Copy link
Contributor Author

mtei commented Apr 24, 2019

As it will likely take time to reproduce the reported issue (#5509 (comment)), we will consider this change as complete and will try to resolve it in a future PR.

@mtei mtei changed the title [WIP] FIX rgblight.c split sync bug FIX rgblight.c split sync bug Apr 24, 2019
@drashna
Copy link
Member

drashna commented Apr 24, 2019

Thanks!

@drashna drashna merged commit 9f8c8c5 into qmk:master Apr 24, 2019
@mtei mtei deleted the rgblight-split-sync-debug branch May 11, 2019 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@mechmerlin mechmerlin Awaiting requested review from mechmerlin

@jackhumbert jackhumbert Awaiting requested review from jackhumbert

@algernon algernon Awaiting requested review from algernon

@ezuk ezuk Awaiting requested review from ezuk

@fredizzimo fredizzimo Awaiting requested review from fredizzimo

@skullydazed skullydazed Awaiting requested review from skullydazed

@yanfali yanfali Awaiting requested review from yanfali

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtei @drashna