Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handwired keyboard "Tennie" #5507

Merged
merged 9 commits into from
Apr 2, 2019
Merged

Add handwired keyboard "Tennie" #5507

merged 9 commits into from
Apr 2, 2019

Conversation

OneMoreByte
Copy link
Contributor

@OneMoreByte OneMoreByte commented Mar 28, 2019

Description

I made a 10 key macropad for a workshop I'm hosting in the next few weeks. I wanted them to pull the code from here, so I though I would make a PR. I was also looking for some feedback if you noticed I did anything goofy. I want everything to go smoothly!

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, can you rename the Soundboard keymap folder to soundboard? QMK is trying to enforce fully-lowercase directory trees because some operating systems (read: Windows) get stupid with mixed case.

keyboards/handwired/tennie/keymaps/Soundboard/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/tennie/keymaps/Soundboard/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/tennie/keymaps/Soundboard/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/tennie/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/tennie/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/tennie/keymaps/test/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/tennie/keymaps/test/keymap.c Outdated Show resolved Hide resolved
keyboards/handwired/tennie/tennie.h Outdated Show resolved Hide resolved
keyboards/handwired/tennie/tennie.h Outdated Show resolved Hide resolved
keyboards/handwired/tennie/tennie.h Outdated Show resolved Hide resolved
@drashna
Copy link
Member

drashna commented Mar 30, 2019

Could you please rename the "test" keymap. IIRC, there are some internal stuff that use the name, and this may cause issues.

@OneMoreByte
Copy link
Contributor Author

I can do that. Correcting now.

@drashna
Copy link
Member

drashna commented Apr 2, 2019

Awesome, nice!

@drashna drashna merged commit 68d8bb2 into qmk:master Apr 2, 2019
StevenWolfe pushed a commit to StevenWolfe/qmk_firmware that referenced this pull request Apr 8, 2019
* Add tennie

* Jacobs Functions

* Switch back to normal layout

* Remove define from old template

* Fix broken keymaps

* Correct style errors, add bootlite

* Update readmes. Rename test keymap

* Missed comma

* Switch rgb from init to post init
danielo515 pushed a commit to danielo515/qmk_firmware that referenced this pull request May 15, 2019
* Add tennie

* Jacobs Functions

* Switch back to normal layout

* Remove define from old template

* Fix broken keymaps

* Correct style errors, add bootlite

* Update readmes. Rename test keymap

* Missed comma

* Switch rgb from init to post init
shimesaba-type0 pushed a commit to shimesaba-type0/qmk_firmware that referenced this pull request Jun 22, 2019
* Add tennie

* Jacobs Functions

* Switch back to normal layout

* Remove define from old template

* Fix broken keymaps

* Correct style errors, add bootlite

* Update readmes. Rename test keymap

* Missed comma

* Switch rgb from init to post init
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
* Add tennie

* Jacobs Functions

* Switch back to normal layout

* Remove define from old template

* Fix broken keymaps

* Correct style errors, add bootlite

* Update readmes. Rename test keymap

* Missed comma

* Switch rgb from init to post init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants