Added idle rgblight timeout feature

[nvitaterna]

Description

This adds an idle timeout features (independent of your PC's sleep settings). In simple terms: if there are no keystrokes after X minutes, turn off the underglow.

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout/userspace (addition or update)
• Documentation

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[nvitaterna]

It might be obvious from looking at the code, but after it has timed out a keystroke will turn on the underglow (only if it was previously turned on prior to timeout).

[drashna]

Honestly, from the looks of this, this is more of an extension of the RGB Light feature, rather than something separate.

And the RGB Matrix has its own version of this, already. So, this really couldn't be extended into it.

Because of that, I'd really rather see this merged more into the rgb light code, and enabled by a define, the way that animations and sleep are.
The plus side of that, is that you could actually use rgblight_task and just "return" out of the function, if the timeout has been hit. This may be a more efficient method to handle this.

(but still, as is, this is pretty awesome!)

Edit: Also, if it helps, there is also timer_read32 and timer_elapsed32 which may be helpful here. (but maybe not)

[nvitaterna]

Thanks for the feedback! I'll work on merging it with the main rgb light code.

[Lenbok]

BTW, when you do your updated version, you should use rgblight_disable_noeeprom and rgblight_enable_noeeprom to do the turning off and on, since the blanking caused by the idle timeout is a transient setting that you do not want saved to eeprom. (e.g, you wouldn't want an unplug of the keyboard while this is timed out to mean that the keyboard next wakes up with rgb disabled.)

[drashna]

Have you had a chance to update this?

[Lenbok]

if @nvitaterna doesn't have bandwidth to update this, I'm happy to take a crack at it (I've been using a userspace version of this feature for a couple of months) - I assume I just open a new PR.

[nvitaterna]

Unfortunately my LEDs are broken right now (supports in the case crushed some) so I'm waiting for replacements. I can get working on it after it's fixed.

…

On Sun, Apr 14, 2019, 2:07 PM Drashna Jaelre ***@***.***> wrote: Have you had a chance to update this? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5475 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGZfiLNKp8ni1-JCVcDRllAoCLCDbS1kks5vg25NgaJpZM4cFKzP> .

[skullydazed]

In an effort to clean up our queue I'm going to close this PR. However, we'd still like to include this feature once it's done! Please feel free to open a new PR when you are ready.