Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -yq flags to actually make debian installs noninteractive #5469

Merged
merged 1 commit into from
Apr 19, 2019

Conversation

mechmerlin
Copy link
Contributor

@mechmerlin mechmerlin commented Mar 23, 2019

Description

I'm assuming that because DEBIAN_FRONTEND=noninteractive is set, we actually want this to be non interactive. However when I run this on my system, it actually is interactive. Adding the -yq flag will fix this.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Copy link
Member

drashna commented Mar 23, 2019

A better question is:

Do we want all of the installs to be non-interactive, and automatically install the build tools?

I know this question has come up for MSYS installs, recently...

@zvecr
Copy link
Member

zvecr commented Mar 23, 2019

The same subject also came up within #4842,

As for the change to linux_install.sh, it seems to be by design that the various install options prompt for confirmation, rather than assume yes. The Ubuntu path being changed deviates away from the others. Should the required change check an environment variable or script argument is set, and only then pass the -y argument? and should this be done for all install targets?

I would say if its decided that debian should be noninteractive, then all platforms should be changed to make it consistent.

@drashna
Copy link
Member

drashna commented Mar 23, 2019

Yeah, I do agree with that. Though, I don't think that we need to change it all at once.

@skullydazed skullydazed merged commit 1ef01ba into qmk:master Apr 19, 2019
@mechmerlin mechmerlin deleted the feature/noninteractive branch October 3, 2019 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants