-
-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added two songs to song_list.h #5252
Conversation
…ames) and TO_BOLDLY_GO (a melody from the main themes of Star Trek TNG and the original series)
On a personal aesthetic level I think to boldly go would work better one octave higher, but if you like it lower we'll merge it like this. :) (Or it may be the difference between audio on AVR and ARM, I'm looking into that.) |
I tested it just now with a Proton-C. Both of these songs sound very different (worse, in my opinion) coming from the Proton-C then they do from any of the AVR boards I've tried them on. Also the timing of both sounds really different to me on the Proton-C. If you're interested, here is a comparison I recorded really quick: TO_BOLDLY_GO (one octave higher as suggested) All I did for the test is copy the default keymap in the proton-c folder and tell it to play the song on startup. I haven't spent much time with ARM since I prefer split boards. |
I talked to @jackhumbert about this, there's some work that needs to be done on the ARM side of things. Apparently the timing and tuning isn't right yet. |
Oh okay. If everything should sound like it does through AVR boards in the end then I do think it sounds better in the lower octave. Though it is definitely better one octave up from the Proton-C. |
Also, rests don't work, IIRC. :( |
Was this waiting on anything, or ready to commit? @skullydazed Any issues with merging as is? |
Adds FF_Prelude (from most Final Fantasy games) and TO_BOLDLY_GO (a melody from the main themes of Star Trek TNG and the original series)
Adds FF_Prelude (from most Final Fantasy games) and TO_BOLDLY_GO (a melody from the main themes of Star Trek TNG and the original series)
Adds FF_Prelude (from most Final Fantasy games) and TO_BOLDLY_GO (a melody from the main themes of Star Trek TNG and the original series)
Adds FF_Prelude (from most Final Fantasy games) and TO_BOLDLY_GO (a melody from the main themes of Star Trek TNG and the original series)
Adds FF_Prelude (from most Final Fantasy games) and TO_BOLDLY_GO (a melody from the main themes of Star Trek TNG and the original series)
Description
I added two songs I use to song_list.h.
First is FF_PRELUDE, which is the opening music to most Final Fantasy games.
Second is TO_BOLDLY_GO, which from the main themes of Star Trek TNG and the original series.
It didn't seem like there was any sort of order to the list of songs, so I just added my two at the very end. Sorry if I missed something there.
Types of Changes
Issues Fixed or Closed by This PR
Checklist