Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added two songs to song_list.h #5252

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Added two songs to song_list.h #5252

merged 1 commit into from
Feb 28, 2019

Conversation

avatak
Copy link
Contributor

@avatak avatak commented Feb 26, 2019

Description

I added two songs I use to song_list.h.

First is FF_PRELUDE, which is the opening music to most Final Fantasy games.

Second is TO_BOLDLY_GO, which from the main themes of Star Trek TNG and the original series.

It didn't seem like there was any sort of order to the list of songs, so I just added my two at the very end. Sorry if I missed something there.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

…ames) and TO_BOLDLY_GO (a melody from the main themes of Star Trek TNG and the original series)
@skullydazed
Copy link
Member

skullydazed commented Feb 26, 2019

On a personal aesthetic level I think to boldly go would work better one octave higher, but if you like it lower we'll merge it like this. :)

(Or it may be the difference between audio on AVR and ARM, I'm looking into that.)

@avatak
Copy link
Contributor Author

avatak commented Feb 26, 2019

On a personal aesthetic level I think to boldly go would work better one octave higher, but if you like it lower we'll merge it like this. :)

(Or it may be the difference between audio on AVR and ARM, I'm looking into that.)

I tested it just now with a Proton-C. Both of these songs sound very different (worse, in my opinion) coming from the Proton-C then they do from any of the AVR boards I've tried them on.

Also the timing of both sounds really different to me on the Proton-C.

If you're interested, here is a comparison I recorded really quick:

TO_BOLDLY_GO (one octave higher as suggested)

FF_PRELUDE

All I did for the test is copy the default keymap in the proton-c folder and tell it to play the song on startup. I haven't spent much time with ARM since I prefer split boards.

@skullydazed
Copy link
Member

I talked to @jackhumbert about this, there's some work that needs to be done on the ARM side of things. Apparently the timing and tuning isn't right yet.

@avatak
Copy link
Contributor Author

avatak commented Feb 27, 2019

Oh okay. If everything should sound like it does through AVR boards in the end then I do think it sounds better in the lower octave. Though it is definitely better one octave up from the Proton-C.

@drashna
Copy link
Member

drashna commented Feb 27, 2019

Also, rests don't work, IIRC. :(

@drashna
Copy link
Member

drashna commented Feb 28, 2019

Was this waiting on anything, or ready to commit?

@skullydazed Any issues with merging as is?

@drashna drashna merged commit 8dd1dab into qmk:master Feb 28, 2019
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Mar 7, 2019
Adds FF_Prelude (from most Final Fantasy games) and TO_BOLDLY_GO (a melody from the main themes of Star Trek TNG and the original series)
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Mar 18, 2019
Adds FF_Prelude (from most Final Fantasy games) and TO_BOLDLY_GO (a melody from the main themes of Star Trek TNG and the original series)
chie4hao pushed a commit to chie4hao/qmk_firmware that referenced this pull request Mar 28, 2019
Adds FF_Prelude (from most Final Fantasy games) and TO_BOLDLY_GO (a melody from the main themes of Star Trek TNG and the original series)
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Apr 3, 2019
Adds FF_Prelude (from most Final Fantasy games) and TO_BOLDLY_GO (a melody from the main themes of Star Trek TNG and the original series)
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
Adds FF_Prelude (from most Final Fantasy games) and TO_BOLDLY_GO (a melody from the main themes of Star Trek TNG and the original series)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants