Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new brightness aliases to keycodes_basic.md #4866

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

fauxpark
Copy link
Member

Description

Just a slight tweak to the changes in #4836:

  • Added the new aliases to keycodes_basic.md as well
  • Aligned the keycode tables again
  • Removed the references to the new aliases in KC_BRIU/D - it makes them seem like they don't work on macOS. I'm pretty sure they work across the board.

And removed some extra newlines in keycodes.md.

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

None.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Copy link
Member

drashna commented Jan 18, 2019

Thanks!

@drashna drashna merged commit ba05f96 into qmk:master Jan 18, 2019
@fauxpark fauxpark deleted the brightness-keycodes-doc branch January 18, 2019 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants