Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added brightness controls and Media controls to my keymap. #4760

Merged
merged 8 commits into from
Jan 2, 2019

Conversation

lbibass
Copy link
Contributor

@lbibass lbibass commented Jan 2, 2019

I was tired of not being able to change brightness and volume and media controls on other macs besides my own, so I added them to my keymap.

Description

Added brightness controls, media controls, and volume controls to my keymap. I added another layer, if I want to use the f keys on MacOS

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mechmerlin mechmerlin merged commit c71c078 into qmk:master Jan 2, 2019
@lbibass
Copy link
Contributor Author

lbibass commented Jan 2, 2019

Thanks for the quick merge Merlin!

rseymour pushed a commit to rseymour/qmk_firmware that referenced this pull request Mar 13, 2019
* Added my Mechmini2 layout to qmk.

* Added more info to the readme.

* Made changes.

* Update keyboards/mechmini/v2/keymaps/lbibass_625_space/keymap.c

Co-Authored-By: lbibass <[email protected]>

* Update keyboards/mechmini/v2/keymaps/lbibass_split_space/keymap.c

Co-Authored-By: lbibass <[email protected]>

* Added brightness and volume controls to MechMini 625 layout.
djthread pushed a commit to djthread/qmk_firmware that referenced this pull request Mar 17, 2019
* Added my Mechmini2 layout to qmk.

* Added more info to the readme.

* Made changes.

* Update keyboards/mechmini/v2/keymaps/lbibass_625_space/keymap.c

Co-Authored-By: lbibass <[email protected]>

* Update keyboards/mechmini/v2/keymaps/lbibass_split_space/keymap.c

Co-Authored-By: lbibass <[email protected]>

* Added brightness and volume controls to MechMini 625 layout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants