Long overdue fixes and improvements to environment setup scripts #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome - thanks :) |
ryaninvents
pushed a commit
to ryaninvents/qmk_firmware
that referenced
this pull request
Aug 12, 2016
…#448) * Update setup script 1 for new folder structure * Improve script 1 output * Launch elevate if run without admin privileges * Improve MinGW error message * Improvements and fixes to second script * Log elevate output in first script
BlueTufa
pushed a commit
to BlueTufa/qmk_firmware
that referenced
this pull request
Aug 6, 2021
Requested by yiancar.
jiaxin96
pushed a commit
to Oh-My-Mechanical-Keyboard/qmk_firmware
that referenced
this pull request
Oct 18, 2023
* add reviung53 vial files * Revert "add reviung53 vial files" This reverts commit 074be536deda760843efda31f0c5ee9dbbb5a5e7. * add aeternus omnibus * add vial files * prettify * fix layouts * add encoder functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most importantly, the SF download links should be working again, and they should be much less likely to need changing in the near future.
The second script also now supports being started as a non-administrator, and requesting to elevate its permissions.
The output is also a bit nicer.
I haven't tested this especially thoroughly, just on my Windows 10 machine.