Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compilation #415

Merged
merged 1 commit into from
Jun 18, 2016
Merged

Improve compilation #415

merged 1 commit into from
Jun 18, 2016

Conversation

eltang
Copy link
Contributor

@eltang eltang commented Jun 17, 2016

  • Copy a change made in TMK that somehow didn’t make it (remove extraneous dfu-programmer commands)
  • Make code size estimates much more meaningful

@jackhumbert
Copy link
Member

The move to testing .hex files was a conscious one, and -C isn't available on all versions of avr-size.

What dfu-programmer commands are you talking about?

@eltang
Copy link
Contributor Author

eltang commented Jun 18, 2016

avr-size strips down the .elf file to what's actually going to go on the chip. The number in the new output is exactly the same as the number in the old output; the only difference is that the size is now also given as a percentage of the space available on the chip (much more useful). Should I change -C to --format=avr?

I'm talking about tmk/tmk_keyboard@d0f1749.

@jackhumbert
Copy link
Member

It does the same to the .hex file. The avr format is also not supported by all versions.

I'd like to keep the size information, but I see the redundant erase - feel free to modify your PR to just that.

@eltang
Copy link
Contributor Author

eltang commented Jun 18, 2016

Done.

@jackhumbert jackhumbert merged commit e175b8d into qmk:master Jun 18, 2016
@eltang
Copy link
Contributor Author

eltang commented Jun 18, 2016

I think some documentation on running avr-size manually would be nice (it took me a while to figure that one out).

@jackhumbert
Copy link
Member

Putting -h after the command usually provides enough. eg avr-size -h.

@eltang
Copy link
Contributor Author

eltang commented Jun 18, 2016

That's not what I meant; learning all the options is easy, but learning that it even exists (and how to make it produce much cleaner output than it does when called by make) is not.

@eltang eltang deleted the compilation_fix branch June 20, 2016 06:15
ryaninvents pushed a commit to ryaninvents/qmk_firmware that referenced this pull request Aug 12, 2016
jiaxin96 pushed a commit to Oh-My-Mechanical-Keyboard/qmk_firmware that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants