Reformat Iris default keymap #3534
Conversation
| ) | ||
|
|
||
| }; | ||
|
|
||
| void persistent_default_layer_set(uint16_t default_layer) { |
There was a problem hiding this comment.
If you're reformatting/refactoring the code, would you mind removing this function (persistent_default_layer_set) and replace all references to it with set_single_persistent_default_layer instead? (it should be called like set_single_persistent_default_layer(_QWERTY))?
| bool process_record_user(uint16_t keycode, keyrecord_t *record) { | ||
| switch (keycode) { | ||
| case QWERTY: | ||
| if (record->event.pressed) { | ||
| persistent_default_layer_set(1UL<<_QWERTY); | ||
| set_single_persistent_default_layer(1UL << _QWERTY); |
There was a problem hiding this comment.
The 1UL << part isn't necessary. The function includes that automatically, so all you need is the layer number/"name".
nooges
force-pushed
the
update-iris-default
branch
from
e495d9e to
4569425
Compare
|
Awesome, thanks! |
* Reformat default keymap to use LAYOUT, move RGB controls to RAISE layer * Use set_single_persistent_default_layer instead of old method
|
@nooges besides changing the small function and changing the layout_kc to layout, which i understand, why the rest of the changes? why remove the rgb buttons etc? |
|
@pvinis Probably to make it easier for him. I agree that the RGB controls should have been kept on the Adjust layer, and that those RGB changes should have been made to his own keymap, but I'm not the person who created the Iris keyboard, so I'm not sure I have much of a say in the matter. I do like the change to LAYOUT instead of LAYOUT_kc, since it makes it easier for me to simply copy-paste my other keymaps into my Iris layout. I can always move the RGB controls on my own keymap.c file to the ADJUST layer if I want. |
|
yeah I was mostly asking for the rbg example essentially getting removed from the default. I guess people who want to find how to do it will find how to do it, same as with every other feature.. |
|
The RGB functions are still in the default, just moved to the Raise layer now to consolidate layers. |
* Reformat default keymap to use LAYOUT, move RGB controls to RAISE layer * Use set_single_persistent_default_layer instead of old method
* Reformat default keymap to use LAYOUT, move RGB controls to RAISE layer * Use set_single_persistent_default_layer instead of old method
No description provided.