Add Comet46 keyboard #3342
Add Comet46 keyboard #3342
Conversation
| // This is the canonical layout file for the Quantum project. If you want to add another keyboard, | ||
|
|
||
| #include QMK_KEYBOARD_H | ||
| #include "action_layer.h" |
There was a problem hiding this comment.
Only the first include should be needed. The other two are redundant.
|
|
||
| const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { | ||
|
|
||
| [_QWERTY] = LAYOUT_kc( |
There was a problem hiding this comment.
Could you switch the default layout format, rather than the LAYOUT_kc?
The LAYOUT_kc macro seems to cause problems for newer users. It's fine for personal keymaps, or even a default_kc keymap. But for the normal default, we would like to avoid the _kc layouts.
| }; | ||
|
|
||
|
|
||
| void persistent_default_layer_set(uint16_t default_layer) { |
There was a problem hiding this comment.
This isn't needed anymore.
See: #3342 (comment)
| switch (keycode) { | ||
| case QWERTY: | ||
| if (record->event.pressed) { | ||
| persistent_default_layer_set(1UL<<_QWERTY); |
There was a problem hiding this comment.
You can use set_single_persistent_default_layer(_QWERTY); here instead, as it handles this, and some additional stuff.
| } | ||
| return false; | ||
| break; | ||
| case LOWER: |
There was a problem hiding this comment.
The tri layer code has changed, so you may not need to use macros here.
If you use the following, you can use ANY layer change keycode (including LT(x, kc)) to activate the tri layer. The downside is that you can then only get to the 3rd layer (Adjust in this case) via the tri layer. But this may free up keys.
uint32_t layer_state_set_user(uint32_t state) {
return update_tri_layer_state(state, _RAISE, _LOWER, _ADJUST);
}This is completely optional though.
|
Just to make sure I wasn't misunderstood, you can still have an Adjust layer, and use the tri layer thing (eg, raise + lower = adjust). You just need the |
|
Thanks for taking time reviewing my code. |
|
Okay, I had a feeling that was the case, but I wanted to make sure. Is this PR ready to do? |
|
Hi drashna, sorry to keep you waiting. The PR should be ready to do now. Thank you so much for your kind support! |
|
It's not a problem. I just wanted to make sure that I didn't merge it before you were ready! And thanks! |
* Initial commit for Comet46 firmware * Update Comet46 README * Add readme to satt keymap of comet46 * Add default keymap for Comet46 * Fix broken link in readme * Delete redundant includes * Modify default keymap & fix LAYOUT macro * Modify satt keymap of Comet46
* Initial commit for Comet46 firmware * Update Comet46 README * Add readme to satt keymap of comet46 * Add default keymap for Comet46 * Fix broken link in readme * Delete redundant includes * Modify default keymap & fix LAYOUT macro * Modify satt keymap of Comet46
* Initial commit for Comet46 firmware * Update Comet46 README * Add readme to satt keymap of comet46 * Add default keymap for Comet46 * Fix broken link in readme * Delete redundant includes * Modify default keymap & fix LAYOUT macro * Modify satt keymap of Comet46
I designed a new keyboard, the Comet46, which is a split wireless column staggered keyboard.
I would appreciate it if you could review my code, and add Comet46 to the list of qmk keyboards.