AL1 Unable to Compile on Configurator #3339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
reviewed
Jul 8, 2018
There was a problem hiding this comment.
If you check the normal matrix.c, the reason this works normally but not here, is that they're defined weakly in the matrix:
https://github.com/qmk/qmk_firmware/blob/master/quantum/matrix.c#L97-L113
keyboards/al1/al1.c
Outdated
| @@ -15,14 +15,6 @@ | |||
| */ | |||
| #include "al1.h" | |||
|
|
|||
| void matrix_init_kb(void) { | |||
There was a problem hiding this comment.
For consistency, these should remain.
keyboards/al1/matrix.c
Outdated
| @@ -28,6 +28,13 @@ inline uint8_t matrix_cols(void) { | |||
| return MATRIX_COLS; | |||
| } | |||
|
|
|||
| void matrix_init_kb(void) { | |||
There was a problem hiding this comment.
For consistency, these should be set as "weak".
|
Well, I meant having the weak defines in the matrix.c file (as the main matrix.c file does that) However, this should be fine, as well. |
alexey-danilov
pushed a commit
to alexey-danilov/qmk_firmware
that referenced
this pull request
Jul 27, 2018
* use QMK_KEYBOARD_H * init_kb and scan_kb need to be in matrix.c to make use of the matrix.h include * Make the routines weak as suggested by Drashna
ChrissiQ
pushed a commit
to ChrissiQ/qmk_firmware
that referenced
this pull request
Sep 25, 2018
* use QMK_KEYBOARD_H * init_kb and scan_kb need to be in matrix.c to make use of the matrix.h include * Make the routines weak as suggested by Drashna
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
* use QMK_KEYBOARD_H * init_kb and scan_kb need to be in matrix.c to make use of the matrix.h include * Make the routines weak as suggested by Drashna
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the Configurator, you get the following
However you don't hit this when making any of the two default keymaps currently in AL1 directory.
The two matrix routines need matrix.h included. I figured it would be better to just define them in matrix. c which already has matrix.h included.