SixKeyBoard refactor #3193
SixKeyBoard refactor #3193
Conversation
| @@ -1,12 +1,12 @@ | |||
|
|
|||
| #include "sixkeyboard.h" | |||
| #include QMK_KEYBOARD_H | |||
| #include "matrix.h" | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Never mind. Checked code, it most likely is.
There was a problem hiding this comment.
I still haven't worked out which files are superseded by using QMK_KEYBOARD_H. Sometimes I can remove multiple lines and sometimes only one.
Generally, I find replacing only the keyboard's .h file works.
There was a problem hiding this comment.
Most of them aren't needed. The keyboard.h includes quantum.h, which includes a majority of the code.
But in some cases...
eeprom.h (not eeconfig.h) is one to NOT remove. userspace h files, and matrix.h are ones to not remove, as well.
But action_layer.h, etc ... are already included by default.
There was a problem hiding this comment.
Thanks for the knowledge @drashna. In past, I've occasionally done a local compile with the keyboard's .h file included directly, then another compile using QMK_KEYBOARD_H in place of as many #includes as I think I can get away with, then compared the hashes of the .hex files at the end.
|
Thanks! |
* Refactor: create matrix macro * Readme changes * Configurator support
* Refactor: create matrix macro * Readme changes * Configurator support
LAYOUTinfo.json