Adding SX60 work by amnobis and configurator settings #3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mechmerlin
reviewed
Jun 4, 2018
| @@ -0,0 +1,92 @@ | |||
| #include "sx60.h" | |||
There was a problem hiding this comment.
Can you change this to be #include QMK_KEYBOARD_H
| @@ -0,0 +1,25 @@ | |||
| #include "sx60.h" | |||
There was a problem hiding this comment.
Can you change this to be #include QMK_KEYBOARD_H
|
Requested changes completed. |
drashna
reviewed
Jun 5, 2018
.vscode/settings.json
Outdated
| @@ -12,6 +12,7 @@ | |||
| "*.c": "c", | |||
| "*.cpp": "cpp", | |||
| "*.hpp": "cpp", | |||
| "xstddef": "c" | |||
| "xstddef": "c", | |||
| "iosfwd": "c" | |||
There was a problem hiding this comment.
Could you revert the changes here?
Remove config change that was added automatically by vscode.
drashna
reviewed
Jun 5, 2018
keyboards/sx60/readme.md
Outdated
|
|
||
|  | ||
|
|
||
| Keyboard Maintainer: [amnobis](https://github.com/amnobis) |
There was a problem hiding this comment.
Could you make sure that these three lines have double spaces at the end of the lines, so that they are parsed correctly?
Otherwise, they'll end up on one line.
fix readme formatting
|
Awesome! Looks good! |
yamad
pushed a commit
to yamad/qmk_firmware
that referenced
this pull request
Apr 10, 2019
* Add SX60 * Add config maps and layouts as well as readmes. * cleanup and fixes * correct readme * add missing closing commenty tag * Changing includes to QMK_KEYBOARD_H * Update settings.json Remove config change that was added automatically by vscode. * Update readme.md fix readme formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual SX60 work was done by @amnobis who made the sx60. I just cleaned it up and added support for the configurator (at least I'm pretty sure).