Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keyboard] add redragon/k715_pro #24950

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

temp4gh
Copy link
Contributor

@temp4gh temp4gh commented Feb 24, 2025

Description

Add support for new keyboard redragon/k715_pro.
Thanx!

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc added on hold needs-core-wireless Waiting on a core-side Wireless/Bluetooth/LPM implementation. labels Feb 24, 2025
@temp4gh
Copy link
Contributor Author

temp4gh commented Feb 24, 2025

Hello Repository Owner/Collaborators,
This commit contained the wireless(Bluetooth) code.If there are any specific concerns, issues, or additional changes needed, please let me know. Your guidance would be greatly appreciated as I want to ensure my submission aligns with the QMK's standards and requirements.
Additionally, if there are any other steps I need to take or if there's an expected timeline for the review process, please feel free to share that information with me.
Many Thanx!

@stewartsoda
Copy link

stewartsoda commented Feb 26, 2025

This implementation appears to be incomplete. It is missing the MO(KC_RALT) functionality to read the battery level and display it on the number row LEDs and the functionality for the "Mac/Win" switch on the bottom of the KB.
Both of these exist in the stock firmware.
This is a good start, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap needs-core-wireless Waiting on a core-side Wireless/Bluetooth/LPM implementation. on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants