Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kikoslab/kl90: fix keymap #24826

Merged
merged 1 commit into from
Jan 18, 2025
Merged

kikoslab/kl90: fix keymap #24826

merged 1 commit into from
Jan 18, 2025

Conversation

fauxpark
Copy link
Member

Description

LAYOUT_all contains a split left shift; the keymap does not reflect this. Also corrected the KC_PIPE next to Enter to KC_NUHS.

image

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team January 18, 2025 05:58
@fauxpark fauxpark merged commit d73c64e into qmk:master Jan 18, 2025
3 checks passed
@fauxpark fauxpark deleted the kl90-fix-keymap branch January 18, 2025 06:19
le4ker pushed a commit to le4ker/lily58-firmware that referenced this pull request Jan 19, 2025
vinniefranco pushed a commit to Good-Great-Grand-Wonderful/qmk_firmware that referenced this pull request Jan 20, 2025
alk-alyss added a commit to alk-alyss/qmk_firmware that referenced this pull request Jan 30, 2025
* 'master' of https://github.com/qmk/qmk_firmware: (221 commits)
  Add Keychron C3 Pro (Red & RGB) (qmk#24874)
  [OS Detection] Improve MacOS detection (qmk#24708)
  Bump vite from 5.2.14 to 5.4.12 in /builddefs/docsgen (qmk#24852)
  Reject keyboard.json next to info.json (qmk#24882)
  Add keyboard clap_studio/flame60 (qmk#24870)
  [Keyboard] Add Support E8ghtyNeo (qmk#24859)
  [License Violation] add pressplayid (qmk#24869)
  Fix missing wait.h include in Dip Switch Map (qmk#24863)
  Add Model-B keyboard (qmk#24681)
  Updated Licence Violations for Chosfox L75 (qmk#24833)
  License violations updates. (qmk#24831)
  Add Lily (qmk#24813)
  `kikoslab/kl90`: fix keymap (qmk#24826)
  [Keyboard] Add ic45v2 (qmk#24818)
  Allow running Docker container on MacOS (without in-container USB support) (qmk#24412)
  `salane/ncr80alpsskfl`: add additional layouts (qmk#24809)
  Bump nanoid from 3.3.7 to 3.3.8 in /builddefs/docsgen (qmk#24713)
  Fix a build warning and tidy up a keymap (qmk#24805)
  [Bug] Fix Underglow keycode processing (qmk#24798)
  [Docs] Fix wording in Mod Tap documentation (qmk#24796)
  ...
Rumadon pushed a commit to Rumadon/qmk_firmware that referenced this pull request Jan 31, 2025
MaximumP pushed a commit to MaximumP/qmk_firmware that referenced this pull request Feb 1, 2025
alinelena pushed a commit to alinelena/qmk_firmware that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants