-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new keyboard epssp75 #24756
base: master
Are you sure you want to change the base?
Added new keyboard epssp75 #24756
Conversation
Note to other maintainers, this has been opened/closed multiple times: #24173, #24545, #24755, and this one. Please ensure all requested changes on those PRs have been addressed. Note to the PR submitter: stop opening new PRs. This is the last one which will be accepted — opening and closing repeatedly wastes everyone’s time due to a loss of context and makes them even less likely to perform reviews. Any more will result in the inability to make PRs entirely. |
@tzarc, I am sorry for how I acted here. I still struggle to think correctly here and understand GitHub. After needing to rename the files and in the next step also relocating them, I thought it was easier to delete my fork and restart from scratch. Which worked for the fork but the traces remain here of course and should be used to provide context, sorry. |
QMK lint still shows an error after the last commit. And it shows the wrong layout.
No worries mate, we have a lot of people who close and open as a way to avoid reviews or to try to “fast track” a PR which they feel isn’t moving as fast as they’d like. We apply this policy to everybody who acts this way. |
Some keys in row 3 had a wrong value on the x axis resulting in some positions being used twice. 1 instead of 11, 2 instead of 12 etc. Also: previous commit reverted.
@waffle87, you already helped me here, but there is one more issue, with which I need help. One of the checks shows: »PR Lint keyboards / lint (pull_request) Failing after 51s«
I cannot reproduce this with Can you help? |
Testing this locally, and doesn't look like there is any issue either. May be a bug with the lint check itself :/ |
Change suggested in comment Co-authored-by: Drashna Jaelre <[email protected]>
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist