Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new keyboard epssp75 #24756

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Added new keyboard epssp75 #24756

wants to merge 7 commits into from

Conversation

hen-des
Copy link

@hen-des hen-des commented Dec 27, 2024

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc
Copy link
Member

tzarc commented Dec 27, 2024

Note to other maintainers, this has been opened/closed multiple times: #24173, #24545, #24755, and this one. Please ensure all requested changes on those PRs have been addressed.

Note to the PR submitter: stop opening new PRs. This is the last one which will be accepted — opening and closing repeatedly wastes everyone’s time due to a loss of context and makes them even less likely to perform reviews. Any more will result in the inability to make PRs entirely.

PR [qmk#24756](qmk#24756)
keyboard.json: formatted and url corrected
keymap.c: tabs replaced with spaces and »_______,« set to mod key in layer 1
@hen-des
Copy link
Author

hen-des commented Dec 27, 2024

@tzarc, I am sorry for how I acted here. I still struggle to think correctly here and understand GitHub. After needing to rename the files and in the next step also relocating them, I thought it was easier to delete my fork and restart from scratch. Which worked for the fork but the traces remain here of course and should be used to provide context, sorry.

QMK lint still shows an error after the last commit. And it shows the wrong layout.
@tzarc
Copy link
Member

tzarc commented Dec 27, 2024

No worries mate, we have a lot of people who close and open as a way to avoid reviews or to try to “fast track” a PR which they feel isn’t moving as fast as they’d like. We apply this policy to everybody who acts this way.

Some keys in row 3 had a wrong value on the x axis resulting in some positions being used twice. 1 instead of 11, 2 instead of 12 etc. Also: previous commit reverted.
@hen-des
Copy link
Author

hen-des commented Dec 27, 2024

@waffle87, you already helped me here, but there is one more issue, with which I need help.

One of the checks shows: »PR Lint keyboards / lint (pull_request) Failing after 51s«
It says »Ψ Lint check passed!« (also locally) but here also:

Error: Requires Formatting
Error: Process completed with exit code 1.

I cannot reproduce this with qmk lint -kb handwired/hen_des/epssp75 locally, so I needed a commit for every attempt I gave it here. But I do not have any further idea, what to change here.

Can you help?

@drashna
Copy link
Member

drashna commented Dec 30, 2024

@waffle87, you already helped me here, but there is one more issue, with which I need help.

One of the checks shows: »PR Lint keyboards / lint (pull_request) Failing after 51s« It says »Ψ Lint check passed!« (also locally) but here also:

Error: Requires Formatting
Error: Process completed with exit code 1.

I cannot reproduce this with qmk lint -kb handwired/hen_des/epssp75 locally, so I needed a commit for every attempt I gave it here. But I do not have any further idea, what to change here.

Can you help?

Testing this locally, and doesn't look like there is any issue either. May be a bug with the lint check itself :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants