Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dactyl Manuform 5x8 keyboard #24742

Closed
wants to merge 19 commits into from
Closed

Add Dactyl Manuform 5x8 keyboard #24742

wants to merge 19 commits into from

Conversation

iliorik
Copy link
Contributor

@iliorik iliorik commented Dec 23, 2024

Description

This pull request add new keyboard to handwired/dactyl_manuform: 5x8.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [*] Keyboard (addition or update)
  • [*] Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [*] My code follows the code style of this project: C, Python
  • [*] I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [*] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@waffle87 waffle87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please not close and open new PRs (#24726). There are numerous suggested changes on your previous PR that have not been addressed even in this new one?

@iliorik
Copy link
Contributor Author

iliorik commented Dec 23, 2024

Please not close and open new PRs (#24726). There are numerous suggested changes on your previous PR that have not been addressed even in this new one?

I rewrote the code in the files taking into account the proposed changes. Can I reopen the old PR?

@waffle87
Copy link
Member

Can I reopen the old PR?

Sure, given that half of the requested changes were not made, it would be best to keep the context there.

@sigprof
Copy link
Contributor

sigprof commented Dec 24, 2024

In order to reopen the old PR, the new PR from the same branch needs to be closed first.

@sigprof sigprof closed this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants