Skip parsing g_led_config when matrix_size is missing #24739
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resurrecting #23941.
While its true this error should generally not happen to valid keyboards, users are constantly tripped up by the python stack trace that is otherwise spat out. This stack trace is output even if the board is not attempting to support RGB/LED matrix.
This wall of text leads them down paths that are irrelevant to their issue. Worse is when reaching out for help, they then post the stack trace (usually as a screenshot...), and not the full output that shows the actual error that triggered
matrix_size
to be undefined.Before:
After:
Types of Changes
Issues Fixed or Closed by This PR
Checklist