fix: mechwild/bb65 coordinate mix-up #24738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
approved these changes
Dec 22, 2024
waffle87
approved these changes
Dec 22, 2024
dpnetca
pushed a commit
to dpnetca/qmk_firmware
that referenced
this pull request
Dec 22, 2024
matoushybl
pushed a commit
to matoushybl/qmk_firmware
that referenced
this pull request
Dec 22, 2024
ilham-agustiawan
pushed a commit
to ilham-agustiawan/qmk_firmware
that referenced
this pull request
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was mis-ordered in the original QMK code, so it slipped under the radar until later scrutiny of the VIA layout definition (written by @D0hnut5 and @nobiliana) and ZMK keyboard definition revealed the inconsistency.
Thanks to @stephondoestech for verifying the correction as no one else had the hardware in-hand. (A real team effort 🫡 )
Types of Changes
Issues Fixed or Closed by This PR
Compare
vs
Checklist