Add Icebreaker keyboard #24723
Open
Add Icebreaker keyboard #24723
+310
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waffle87
requested changes
Dec 16, 2024
Co-authored-by: jack <[email protected]>
Co-authored-by: jack <[email protected]>
…mk_firmware into dev_icebreaker_rf
waffle87
approved these changes
Dec 16, 2024
fauxpark
requested changes
Dec 16, 2024
Co-authored-by: Ryan <[email protected]>
drashna
requested changes
Dec 18, 2024
| @@ -0,0 +1,240 @@ | |||
| { | |||
| "manufacturer": "Serene Studio", | |||
| "keyboard_name": "Serene Industries - Icebreaker HS", | |||
There was a problem hiding this comment.
Suggested change
| "keyboard_name": "Serene Industries - Icebreaker HS", | |
| "keyboard_name": "Icebreaker HS", |
| {"matrix": [0, 13], "x": 13, "y": 0}, | ||
| {"matrix": [2, 13], "x": 14, "y": 0}, | ||
| {"matrix": [0, 14], "x": 15, "y": 0}, | ||
| {"label": "encoder", "matrix": [3, 1], "x": 16, "y": 0}, |
There was a problem hiding this comment.
Suggested change
| {"label": "encoder", "matrix": [3, 1], "x": 16, "y": 0}, | |
| {"label": "encoder", "matrix": [3, 1], "x": 16, "y": 0, "encoder": 0}, |
| ] | ||
| } | ||
| } | ||
| } |
| [0] = { ENCODER_CCW_CW(KC_VOLD, KC_VOLU) }, | ||
| [1] = { ENCODER_CCW_CW(RM_SATD, RM_SATU) }, | ||
| }; | ||
| #endif |
Comment on lines
+40
to
+41
| [0] = { ENCODER_CCW_CW(KC_VOLD, KC_VOLU) }, | ||
| [1] = { ENCODER_CCW_CW(RM_SATD, RM_SATU) }, |
There was a problem hiding this comment.
Nit:
Suggested change
| [0] = { ENCODER_CCW_CW(KC_VOLD, KC_VOLU) }, | |
| [1] = { ENCODER_CCW_CW(RM_SATD, RM_SATU) }, | |
| [0] = { ENCODER_CCW_CW(KC_VOLD, KC_VOLU) }, | |
| [1] = { ENCODER_CCW_CW(RM_SATD, RM_SATU) }, |
| @@ -0,0 +1 @@ | |||
| ENCODER_MAP_ENABLE = yes | |||
There was a problem hiding this comment.
Suggested change
| ENCODER_MAP_ENABLE = yes | |
| ENCODER_MAP_ENABLE = yes | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addition of the Icebreaker, 65% PCB featuring encoder and per-key RGB.
Types of Changes
Issues Fixed or Closed by This PR
Checklist