Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added VT-40 keyboard #24706

Merged
merged 10 commits into from
Dec 12, 2024
Merged

Added VT-40 keyboard #24706

merged 10 commits into from
Dec 12, 2024

Conversation

guidoism
Copy link
Contributor

Description

Added VT-40 keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [ x] Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [ x] My code follows the code style of this project: C, Python
  • [ x] I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@waffle87 waffle87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you tidy up the keymap and remove the code that does not apply to this keyboard (and was copy and pasted from the default Planck keymap) like audio and midi keycodes, other audio code, etc.

keyboards/vt40/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/vt40/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/vt40/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/vt40/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@waffle87 waffle87 requested a review from a team December 11, 2024 20:28
dunk2k
dunk2k suggested changes Dec 11, 2024
View reviewed changes
keyboards/vt40/keyboard.json Outdated Show resolved Hide resolved
@guidoism @dunk2k
Update keyboards/vt40/keyboard.json
5e859b5 
Co-authored-by: Duncan Sutherland <[email protected]>
@waffle87 waffle87 merged commit d589dbb into qmk:master Dec 12, 2024
3 checks passed
kevinpanaro pushed a commit to kevinpanaro/qmk_firmware that referenced this pull request Dec 18, 2024
@guidoism @waffle87 @dunk2k
Added VT-40 keyboard (qmk#24706)
e4f2f3f 
* Added VT-40 keyboard

* Remove commented out code. Oops

Co-authored-by: jack <[email protected]>

* Change name of planck_layers to layers.

Co-authored-by: jack <[email protected]>

* Update keyboards/vt40/keymaps/default/keymap.c

Co-authored-by: jack <[email protected]>

* Removed unused features that I stole from the contra config

* Removed unused features that I stole from the contra config

* fixed lower/raise keys

* make adjust layer accessible

* Added adjust key for real this time

* Update keyboards/vt40/keyboard.json

Co-authored-by: Duncan Sutherland <[email protected]>

---------

Co-authored-by: jack <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
dpnetca pushed a commit to dpnetca/qmk_firmware that referenced this pull request Dec 22, 2024
@guidoism @waffle87
@dunk2k @dpnetca
Added VT-40 keyboard (qmk#24706)
da59f0a 
* Added VT-40 keyboard

* Remove commented out code. Oops

Co-authored-by: jack <[email protected]>

* Change name of planck_layers to layers.

Co-authored-by: jack <[email protected]>

* Update keyboards/vt40/keymaps/default/keymap.c

Co-authored-by: jack <[email protected]>

* Removed unused features that I stole from the contra config

* Removed unused features that I stole from the contra config

* fixed lower/raise keys

* make adjust layer accessible

* Added adjust key for real this time

* Update keyboards/vt40/keyboard.json

Co-authored-by: Duncan Sutherland <[email protected]>

---------

Co-authored-by: jack <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Dec 24, 2024
@guidoism @waffle87
@dunk2k @ilham-agustiawan
Added VT-40 keyboard (qmk#24706)
de90299 
* Added VT-40 keyboard

* Remove commented out code. Oops

Co-authored-by: jack <[email protected]>

* Change name of planck_layers to layers.

Co-authored-by: jack <[email protected]>

* Update keyboards/vt40/keymaps/default/keymap.c

Co-authored-by: jack <[email protected]>

* Removed unused features that I stole from the contra config

* Removed unused features that I stole from the contra config

* fixed lower/raise keys

* make adjust layer accessible

* Added adjust key for real this time

* Update keyboards/vt40/keyboard.json

Co-authored-by: Duncan Sutherland <[email protected]>

---------

Co-authored-by: jack <[email protected]>
Co-authored-by: Duncan Sutherland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k requested changes

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guidoism @drashna @waffle87 @dunk2k