Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DecenTKL main keyboard #24702

Merged
merged 6 commits into from
Dec 24, 2024
Merged

DecenTKL main keyboard #24702

merged 6 commits into from
Dec 24, 2024

Conversation

bleroy
Copy link
Contributor

@bleroy bleroy commented Dec 10, 2024

This is the firmware customization for the open source DecenTKL keyboard, inspired by the Atari XE and ST design.

Description

Adds support for the keyboard's matrix, RGB LED matrix, OLED screen.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fauxpark
fauxpark requested changes Dec 10, 2024
View reviewed changes
keyboards/decent/tkl/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/decent/tkl/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/decent/tkl/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/decent/tkl/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/decent/tkl/keymaps/default/keymap.c Outdated Show resolved Hide resolved
dunk2k
dunk2k suggested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conforms to PR checklist regarding singular layout

keyboards/decent/tkl/keyboard.json Outdated Show resolved Hide resolved
keyboards/decent/tkl/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/decent/tkl/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@bleroy
Copy link
Contributor Author

bleroy commented Dec 11, 2024

Thanks for the review. I think I addressed everything, please let me know if I missed anything.

zvecr
zvecr requested changes Dec 11, 2024
View reviewed changes
keyboards/decent/tkl/config.h Show resolved Hide resolved
keyboards/decent/tkl/keyboard.json Outdated Show resolved Hide resolved
@bleroy bleroy requested review from fauxpark and zvecr December 13, 2024 18:48
fauxpark
fauxpark requested changes Dec 13, 2024
View reviewed changes
keyboards/decent/tkl/tkl.cs Outdated Show resolved Hide resolved
@bleroy bleroy requested a review from fauxpark December 13, 2024 21:22
waffle87
waffle87 requested changes Dec 14, 2024
View reviewed changes
keyboards/decent/tkl/tkl.c Show resolved Hide resolved
keyboards/decent/tkl/tkl.c Show resolved Hide resolved
@bleroy bleroy requested a review from waffle87 December 14, 2024 20:29
drashna
drashna requested changes Dec 22, 2024
View reviewed changes
keyboards/decent/tkl/tkl.c Outdated Show resolved Hide resolved
@drashna drashna merged commit 18cca20 into qmk:master Dec 24, 2024
3 checks passed
dpnetca pushed a commit to dpnetca/qmk_firmware that referenced this pull request Dec 24, 2024
@bleroy
DecenTKL main keyboard (qmk#24702)
b985f42
@bleroy bleroy deleted the bleroy/decenTKL-default branch December 24, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k requested changes

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bleroy @drashna @fauxpark @zvecr @waffle87 @dunk2k