-
-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DecenTKL numpad #24696
DecenTKL numpad #24696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the PR checklist:
- PRs should contain the smallest amount of modifications required for a single change to the codebase
- multiple keyboards at the same time is not acceptable
- the smaller the PR, the higher likelihood of a quicker review, higher likelihood of quicker merge, and less chance of conflicts
Please remove the keyboards/decent/tkl
code from this pull request and submit it in another.
I addressed what I could but there are still a few unclear comments. Thanks for your review. |
Are there specific things you have questions about? |
Ah yes, apologies, I forgot to publish my review. That's now done. Mainly, I'm not sure where to move the joystick config stuff since I didn't find relevant documentation. There are also minor questions around RGB constants. Thanks for the quick turnout on PRs, that's quite amazing. |
I addressed more comments. Please let me know if anything more is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
layout information additions to match keymap diagram
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A number of small nit picks
This is the firmware customization for the open source DecenTKL numpad, inspired by the Atari XE and ST design.
Description
The customization sets up the matrices for the numpad, adds Atari joystick support.
Types of Changes
Issues Fixed or Closed by This PR
None
Checklist