Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: KC_MEDIA_PLAY_PAUSE label #24693

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix: KC_MEDIA_PLAY_PAUSE label #24693

merged 1 commit into from
Dec 9, 2024

Conversation

tenstad
Copy link
Contributor

@tenstad tenstad commented Dec 8, 2024 •
edited
Loading

Fixes label for KC_MEDIA_PLAY_PAUSE

New label was copied from

qmk_firmware/docs/keycodes_basic.md

Line 209 in 782f91a

|`KC_MEDIA_PLAY_PAUSE` |`KC_MPLY`|Play/Pause Track |

Description

Not sure if this should be fixed in the old version, or if a new one should be created. Did not find the key in any other versions.

Feel free to close if this update is not desired.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the dd Data Driven Changes label Dec 8, 2024
@waffle87 waffle87 merged commit 379bb77 into qmk:master Dec 9, 2024
3 checks passed
pull bot pushed a commit to kruton/qmk_firmware that referenced this pull request Dec 9, 2024
@tenstad @pull
fix: KC_MEDIA_PLAY_PAUSE label (qmk#24693)
7b031b5
eliseomartelli pushed a commit to eliseomartelli/qmk_firmware that referenced this pull request Dec 9, 2024
@tenstad @eliseomartelli
fix: KC_MEDIA_PLAY_PAUSE label (qmk#24693)
d57ff89
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@tenstad @SyrupSplashin
fix: KC_MEDIA_PLAY_PAUSE label (qmk#24693)
e4702cc
kevinpanaro pushed a commit to kevinpanaro/qmk_firmware that referenced this pull request Dec 18, 2024
@tenstad
fix: KC_MEDIA_PLAY_PAUSE label (qmk#24693)
ec32a51
dpnetca pushed a commit to dpnetca/qmk_firmware that referenced this pull request Dec 22, 2024
@tenstad @dpnetca
fix: KC_MEDIA_PLAY_PAUSE label (qmk#24693)
74cd61c
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Dec 24, 2024
@tenstad @ilham-agustiawan
fix: KC_MEDIA_PLAY_PAUSE label (qmk#24693)
ed6fe51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
dd Data Driven Changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tenstad @drashna @waffle87